1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/prism] Rename librubyparser to libprism

Browse Source 
librubyparser was an artifact of the prototype that was initially
named ruby-parser. Instead, this renames it to libprism to be
consistent with the actual name.

https://github.com/ruby/prism/commit/8600b06811
This commit is contained in:
Kevin Newton 2023-11-10 00:31:07 -05:00
parent 80e379bda1
commit ed75518192
No known key found for this signature in database
GPG Key ID: 0EAD74C79EC73F26
3 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/prism/ffi.rb
View File

@ -14,7 +14,7 @@ module Prism
# Define the library that we will be pulling functions from. Note that this
# must align with the build shared library from make/rake.
ffi_lib File.expand_path("../../build/librubyparser.#{RbConfig::CONFIG["SOEXT"]}", __dir__)
ffi_lib File.expand_path("../../build/libprism.#{RbConfig::CONFIG["SOEXT"]}", __dir__)
# Convert a native C type declaration into a symbol that FFI understands.
# For example:

2
prism/extension.c
View File

@ -1,7 +1,7 @@
#include "prism/extension.h"
// NOTE: this file should contain only bindings. All non-trivial logic should be
// in librubyparser so it can be shared its the various callers.
// in libprism so it can be shared its the various callers.
VALUE rb_cPrism;
VALUE rb_cPrismNode;

28
test/prism/library_symbols_test.rb
View File

@ -13,8 +13,8 @@ module Prism
def setup
super
@librubyparser_a = File.expand_path("../../build/librubyparser.a", __dir__)
@librubyparser_so = File.expand_path("../../build/librubyparser.so", __dir__)
@libprism_a = File.expand_path("../../build/libprism.a", __dir__)
@libprism_so = File.expand_path("../../build/libprism.so", __dir__)
@prism_so = File.expand_path("../../lib/prism/prism.so", __dir__)
end
@ -56,34 +56,34 @@ module Prism
end
#
# static archive - librubyparser.a
# static archive - libprism.a
#
def test_librubyparser_a_contains_nothing_globally_visible
omit("librubyparser.a is not built") unless File.exist?(@librubyparser_a)
def test_libprism_a_contains_nothing_globally_visible
omit("libprism.a is not built") unless File.exist?(@libprism_a)
assert_empty(names(visible_global_objdump_symbols(@librubyparser_a)))
assert_empty(names(visible_global_objdump_symbols(@libprism_a)))
end
def test_librubyparser_a_contains_hidden_pm_symbols
omit("librubyparser.a is not built") unless File.exist?(@librubyparser_a)
def test_libprism_a_contains_hidden_pm_symbols
omit("libprism.a is not built") unless File.exist?(@libprism_a)
names(hidden_global_objdump_symbols(@librubyparser_a)).tap do |symbols|
names(hidden_global_objdump_symbols(@libprism_a)).tap do |symbols|
assert_includes(symbols, "pm_parse")
assert_includes(symbols, "pm_version")
end
end
#
# shared object - librubyparser.so
# shared object - libprism.so
#
def test_librubyparser_so_exports_only_the_necessary_functions
omit("librubyparser.so is not built") unless File.exist?(@librubyparser_so)
def test_libprism_so_exports_only_the_necessary_functions
omit("libprism.so is not built") unless File.exist?(@libprism_so)
names(global_nm_symbols(@librubyparser_so)).tap do |symbols|
names(global_nm_symbols(@libprism_so)).tap do |symbols|
assert_includes(symbols, "pm_parse")
assert_includes(symbols, "pm_version")
end
names(local_nm_symbols(@librubyparser_so)).tap do |symbols|
names(local_nm_symbols(@libprism_so)).tap do |symbols|
assert_includes(symbols, "pm_encoding_shift_jis_isupper_char")
end
# TODO: someone who uses this library needs to finish this test