From ed755181925da920b8a9b07e167e92f3950d1b2a Mon Sep 17 00:00:00 2001 From: Kevin Newton Date: Fri, 10 Nov 2023 00:31:07 -0500 Subject: [PATCH] [ruby/prism] Rename librubyparser to libprism librubyparser was an artifact of the prototype that was initially named ruby-parser. Instead, this renames it to libprism to be consistent with the actual name. https://github.com/ruby/prism/commit/8600b06811 --- lib/prism/ffi.rb | 2 +- prism/extension.c | 2 +- test/prism/library_symbols_test.rb | 28 ++++++++++++++-------------- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/prism/ffi.rb b/lib/prism/ffi.rb index 96102201b3..e1d3e0dca7 100644 --- a/lib/prism/ffi.rb +++ b/lib/prism/ffi.rb @@ -14,7 +14,7 @@ module Prism # Define the library that we will be pulling functions from. Note that this # must align with the build shared library from make/rake. - ffi_lib File.expand_path("../../build/librubyparser.#{RbConfig::CONFIG["SOEXT"]}", __dir__) + ffi_lib File.expand_path("../../build/libprism.#{RbConfig::CONFIG["SOEXT"]}", __dir__) # Convert a native C type declaration into a symbol that FFI understands. # For example: diff --git a/prism/extension.c b/prism/extension.c index 7046154320..9ecd1e30da 100644 --- a/prism/extension.c +++ b/prism/extension.c @@ -1,7 +1,7 @@ #include "prism/extension.h" // NOTE: this file should contain only bindings. All non-trivial logic should be -// in librubyparser so it can be shared its the various callers. +// in libprism so it can be shared its the various callers. VALUE rb_cPrism; VALUE rb_cPrismNode; diff --git a/test/prism/library_symbols_test.rb b/test/prism/library_symbols_test.rb index c8eedb0674..d8eb96e257 100644 --- a/test/prism/library_symbols_test.rb +++ b/test/prism/library_symbols_test.rb @@ -13,8 +13,8 @@ module Prism def setup super - @librubyparser_a = File.expand_path("../../build/librubyparser.a", __dir__) - @librubyparser_so = File.expand_path("../../build/librubyparser.so", __dir__) + @libprism_a = File.expand_path("../../build/libprism.a", __dir__) + @libprism_so = File.expand_path("../../build/libprism.so", __dir__) @prism_so = File.expand_path("../../lib/prism/prism.so", __dir__) end @@ -56,34 +56,34 @@ module Prism end # - # static archive - librubyparser.a + # static archive - libprism.a # - def test_librubyparser_a_contains_nothing_globally_visible - omit("librubyparser.a is not built") unless File.exist?(@librubyparser_a) + def test_libprism_a_contains_nothing_globally_visible + omit("libprism.a is not built") unless File.exist?(@libprism_a) - assert_empty(names(visible_global_objdump_symbols(@librubyparser_a))) + assert_empty(names(visible_global_objdump_symbols(@libprism_a))) end - def test_librubyparser_a_contains_hidden_pm_symbols - omit("librubyparser.a is not built") unless File.exist?(@librubyparser_a) + def test_libprism_a_contains_hidden_pm_symbols + omit("libprism.a is not built") unless File.exist?(@libprism_a) - names(hidden_global_objdump_symbols(@librubyparser_a)).tap do |symbols| + names(hidden_global_objdump_symbols(@libprism_a)).tap do |symbols| assert_includes(symbols, "pm_parse") assert_includes(symbols, "pm_version") end end # - # shared object - librubyparser.so + # shared object - libprism.so # - def test_librubyparser_so_exports_only_the_necessary_functions - omit("librubyparser.so is not built") unless File.exist?(@librubyparser_so) + def test_libprism_so_exports_only_the_necessary_functions + omit("libprism.so is not built") unless File.exist?(@libprism_so) - names(global_nm_symbols(@librubyparser_so)).tap do |symbols| + names(global_nm_symbols(@libprism_so)).tap do |symbols| assert_includes(symbols, "pm_parse") assert_includes(symbols, "pm_version") end - names(local_nm_symbols(@librubyparser_so)).tap do |symbols| + names(local_nm_symbols(@libprism_so)).tap do |symbols| assert_includes(symbols, "pm_encoding_shift_jis_isupper_char") end # TODO: someone who uses this library needs to finish this test