1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove meaningless NULL checks

Browse Source 
The functions dereference `*dead_entry` without a NULL check
This commit is contained in:
Yusuke Endoh 2024-12-04 16:33:49 +09:00
parent 3b27818062
commit d2c55e33fb
Notes: git 2024-12-04 08:12:55 +00:00 
Merged: https://github.com/ruby/ruby/pull/12258
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
weakmap.c
View File

@ -636,10 +636,8 @@ static int
wkmap_mark_table_i(st_data_t key, st_data_t val_obj, st_data_t data) wkmap_mark_table_i(st_data_t key, st_data_t val_obj, st_data_t data)
{ {
VALUE **dead_entry = (VALUE **)data; VALUE **dead_entry = (VALUE **)data;
if (dead_entry != NULL) {
ruby_sized_xfree(*dead_entry, sizeof(VALUE)); ruby_sized_xfree(*dead_entry, sizeof(VALUE));
*dead_entry = NULL; *dead_entry = NULL;
}
VALUE *key_ptr = (VALUE *)key; VALUE *key_ptr = (VALUE *)key;
@ -702,10 +700,8 @@ static int
wkmap_compact_table_i(st_data_t key, st_data_t val_obj, st_data_t data, int _error) wkmap_compact_table_i(st_data_t key, st_data_t val_obj, st_data_t data, int _error)
{ {
VALUE **dead_entry = (VALUE **)data; VALUE **dead_entry = (VALUE **)data;
if (dead_entry != NULL) {
ruby_sized_xfree(*dead_entry, sizeof(VALUE)); ruby_sized_xfree(*dead_entry, sizeof(VALUE));
*dead_entry = NULL; *dead_entry = NULL;
}
VALUE *key_ptr = (VALUE *)key; VALUE *key_ptr = (VALUE *)key;