From d2c55e33fb4cf22859ef5c70fe532342d7bb2c62 Mon Sep 17 00:00:00 2001 From: Yusuke Endoh Date: Wed, 4 Dec 2024 16:33:49 +0900 Subject: [PATCH] Remove meaningless NULL checks The functions dereference `*dead_entry` without a NULL check --- weakmap.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/weakmap.c b/weakmap.c index 32acf2d6ec..f8a6ae3747 100644 --- a/weakmap.c +++ b/weakmap.c @@ -636,10 +636,8 @@ static int wkmap_mark_table_i(st_data_t key, st_data_t val_obj, st_data_t data) { VALUE **dead_entry = (VALUE **)data; - if (dead_entry != NULL) { - ruby_sized_xfree(*dead_entry, sizeof(VALUE)); - *dead_entry = NULL; - } + ruby_sized_xfree(*dead_entry, sizeof(VALUE)); + *dead_entry = NULL; VALUE *key_ptr = (VALUE *)key; @@ -702,10 +700,8 @@ static int wkmap_compact_table_i(st_data_t key, st_data_t val_obj, st_data_t data, int _error) { VALUE **dead_entry = (VALUE **)data; - if (dead_entry != NULL) { - ruby_sized_xfree(*dead_entry, sizeof(VALUE)); - *dead_entry = NULL; - } + ruby_sized_xfree(*dead_entry, sizeof(VALUE)); + *dead_entry = NULL; VALUE *key_ptr = (VALUE *)key;