1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

get_envparam_double: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-15 14:36:41 +09:00
parent 228118482e
commit c5f4345138
Notes: git 2020-06-29 11:07:05 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gc.c
View File

@ -9389,13 +9389,15 @@ get_envparam_double(const char *name, double *default_value, double lower_bound,
} }
} }
else { else {
accept: goto accept;
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (default value: %f)\n", name, val, *default_value);
*default_value = val;
return 1;
} }
} }
return 0; return 0;
accept:
if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (default value: %f)\n", name, val, *default_value);
*default_value = val;
return 1;
} }
static void static void