From c5f43451389a9a19d14c34e553d271038a87be99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= Date: Mon, 15 Jun 2020 14:36:41 +0900 Subject: [PATCH] get_envparam_double: do not goto into a branch I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor. --- gc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gc.c b/gc.c index 05b8fb3b45..a2a7997a72 100644 --- a/gc.c +++ b/gc.c @@ -9389,13 +9389,15 @@ get_envparam_double(const char *name, double *default_value, double lower_bound, } } else { - accept: - if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (default value: %f)\n", name, val, *default_value); - *default_value = val; - return 1; + goto accept; } } return 0; + + accept: + if (RTEST(ruby_verbose)) fprintf(stderr, "%s=%f (default value: %f)\n", name, val, *default_value); + *default_value = val; + return 1; } static void