[rubygems/rubygems] Run specs that now pass on JRuby

https://github.com/rubygems/rubygems/commit/2af077ee38
This commit is contained in:
David Rodríguez 2024-10-04 17:56:02 +02:00 committed by git
parent 82c76f1896
commit a1492ffdc2
5 changed files with 6 additions and 16 deletions

View File

@ -215,7 +215,7 @@ class TestGemCommandsExecCommand < Gem::TestCase
end end
def test_gem_with_platform_and_platform_dependencies def test_gem_with_platform_and_platform_dependencies
pend "extensions don't quite work on jruby" if Gem.java_platform? pend "needs investigation" if Gem.java_platform?
pend "terminates on mswin" if vc_windows? && ruby_repo? pend "terminates on mswin" if vc_windows? && ruby_repo?
spec_fetcher do |fetcher| spec_fetcher do |fetcher|

View File

@ -1567,7 +1567,7 @@ end
end end
def test_find_lib_file_after_install def test_find_lib_file_after_install
pend "extensions don't quite work on jruby" if Gem.java_platform? pend "needs investigation" if Gem.java_platform?
@spec = setup_base_spec @spec = setup_base_spec
@spec.extensions << "extconf.rb" @spec.extensions << "extconf.rb"
@ -1655,7 +1655,7 @@ end
end end
def test_install_extension_flat def test_install_extension_flat
pend "extensions don't quite work on jruby" if Gem.java_platform? pend "needs investigation" if Gem.java_platform?
begin begin
@spec = setup_base_spec @spec = setup_base_spec
@ -1693,7 +1693,7 @@ end
end end
def test_install_extension_clean_intermediate_files def test_install_extension_clean_intermediate_files
pend "extensions don't quite work on jruby" if Gem.java_platform? pend "needs investigation" if Gem.java_platform?
@spec = setup_base_spec @spec = setup_base_spec
@spec.require_paths = ["."] @spec.require_paths = ["."]
@spec.extensions << "extconf.rb" @spec.extensions << "extconf.rb"

View File

@ -1334,7 +1334,6 @@ dependencies: []
end end
def test_build_args def test_build_args
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
assert_empty @ext.build_args assert_empty @ext.build_args
@ -1351,7 +1350,6 @@ dependencies: []
end end
def test_build_extensions def test_build_extensions
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
assert_path_not_exist @ext.extension_dir, "sanity check" assert_path_not_exist @ext.extension_dir, "sanity check"
@ -1387,7 +1385,6 @@ dependencies: []
end end
def test_build_extensions_built def test_build_extensions_built
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
refute_empty @ext.extensions, "sanity check" refute_empty @ext.extensions, "sanity check"
@ -1426,7 +1423,6 @@ dependencies: []
end end
def test_build_extensions_error def test_build_extensions_error
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
refute_empty @ext.extensions, "sanity check" refute_empty @ext.extensions, "sanity check"
@ -1440,7 +1436,7 @@ dependencies: []
pend "chmod not supported" if Gem.win_platform? pend "chmod not supported" if Gem.win_platform?
pend "skipped in root privilege" if Process.uid.zero? pend "skipped in root privilege" if Process.uid.zero?
pend "extensions don't quite work on jruby" if Gem.java_platform? pend "needs investigation" if Gem.java_platform?
ext_spec ext_spec
refute_empty @ext.extensions, "sanity check" refute_empty @ext.extensions, "sanity check"
@ -1473,7 +1469,6 @@ dependencies: []
def test_build_extensions_no_extensions_dir_unwritable def test_build_extensions_no_extensions_dir_unwritable
pend "chmod not supported" if Gem.win_platform? pend "chmod not supported" if Gem.win_platform?
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
refute_empty @ext.extensions, "sanity check" refute_empty @ext.extensions, "sanity check"
@ -1512,7 +1507,6 @@ dependencies: []
end end
def test_build_extensions_preview def test_build_extensions_preview
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
extconf_rb = File.join @ext.gem_dir, @ext.extensions.first extconf_rb = File.join @ext.gem_dir, @ext.extensions.first
@ -1547,7 +1541,6 @@ dependencies: []
end end
def test_contains_requirable_file_eh_extension def test_contains_requirable_file_eh_extension
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
_, err = capture_output do _, err = capture_output do
@ -3843,7 +3836,6 @@ end
end end
def test_missing_extensions_eh def test_missing_extensions_eh
pend "extensions don't quite work on jruby" if Gem.java_platform?
ext_spec ext_spec
assert @ext.missing_extensions? assert @ext.missing_extensions?

View File

@ -66,7 +66,6 @@ class TestStubSpecification < Gem::TestCase
end end
def test_contains_requirable_file_eh_extension def test_contains_requirable_file_eh_extension
pend "I guess making the stub match the running platform should work" if Gem.java_platform?
stub_with_extension do |stub| stub_with_extension do |stub|
_, err = capture_output do _, err = capture_output do
refute stub.contains_requirable_file? "nonexistent" refute stub.contains_requirable_file? "nonexistent"
@ -123,7 +122,6 @@ class TestStubSpecification < Gem::TestCase
end end
def test_missing_extensions_eh def test_missing_extensions_eh
pend "I guess making the stub match the running platform should work" if Gem.java_platform?
stub = stub_with_extension do |s| stub = stub_with_extension do |s|
extconf_rb = File.join s.gem_dir, s.extensions.first extconf_rb = File.join s.gem_dir, s.extensions.first
FileUtils.mkdir_p File.dirname extconf_rb FileUtils.mkdir_p File.dirname extconf_rb

View File

@ -130,7 +130,7 @@ class TestGemRequire < Gem::TestCase
end end
def test_dash_i_respects_default_library_extension_priority def test_dash_i_respects_default_library_extension_priority
pend "extensions don't quite work on jruby" if Gem.java_platform? pend "needs investigation" if Gem.java_platform?
pend "not installed yet" unless RbConfig::TOPDIR pend "not installed yet" unless RbConfig::TOPDIR
dash_i_ext_arg = util_install_extension_file("a") dash_i_ext_arg = util_install_extension_file("a")