From a1492ffdc24ae96ea06f4549467211f8d0bbe675 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Fri, 4 Oct 2024 17:56:02 +0200 Subject: [PATCH] [rubygems/rubygems] Run specs that now pass on JRuby https://github.com/rubygems/rubygems/commit/2af077ee38 --- test/rubygems/test_gem_commands_exec_command.rb | 2 +- test/rubygems/test_gem_installer.rb | 6 +++--- test/rubygems/test_gem_specification.rb | 10 +--------- test/rubygems/test_gem_stub_specification.rb | 2 -- test/rubygems/test_require.rb | 2 +- 5 files changed, 6 insertions(+), 16 deletions(-) diff --git a/test/rubygems/test_gem_commands_exec_command.rb b/test/rubygems/test_gem_commands_exec_command.rb index c632ce62b2..b9d5888068 100644 --- a/test/rubygems/test_gem_commands_exec_command.rb +++ b/test/rubygems/test_gem_commands_exec_command.rb @@ -215,7 +215,7 @@ class TestGemCommandsExecCommand < Gem::TestCase end def test_gem_with_platform_and_platform_dependencies - pend "extensions don't quite work on jruby" if Gem.java_platform? + pend "needs investigation" if Gem.java_platform? pend "terminates on mswin" if vc_windows? && ruby_repo? spec_fetcher do |fetcher| diff --git a/test/rubygems/test_gem_installer.rb b/test/rubygems/test_gem_installer.rb index 12149b9f91..83e43c135f 100644 --- a/test/rubygems/test_gem_installer.rb +++ b/test/rubygems/test_gem_installer.rb @@ -1567,7 +1567,7 @@ end end def test_find_lib_file_after_install - pend "extensions don't quite work on jruby" if Gem.java_platform? + pend "needs investigation" if Gem.java_platform? @spec = setup_base_spec @spec.extensions << "extconf.rb" @@ -1655,7 +1655,7 @@ end end def test_install_extension_flat - pend "extensions don't quite work on jruby" if Gem.java_platform? + pend "needs investigation" if Gem.java_platform? begin @spec = setup_base_spec @@ -1693,7 +1693,7 @@ end end def test_install_extension_clean_intermediate_files - pend "extensions don't quite work on jruby" if Gem.java_platform? + pend "needs investigation" if Gem.java_platform? @spec = setup_base_spec @spec.require_paths = ["."] @spec.extensions << "extconf.rb" diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb index d434ea96f3..929ec9e503 100644 --- a/test/rubygems/test_gem_specification.rb +++ b/test/rubygems/test_gem_specification.rb @@ -1334,7 +1334,6 @@ dependencies: [] end def test_build_args - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec assert_empty @ext.build_args @@ -1351,7 +1350,6 @@ dependencies: [] end def test_build_extensions - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec assert_path_not_exist @ext.extension_dir, "sanity check" @@ -1387,7 +1385,6 @@ dependencies: [] end def test_build_extensions_built - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec refute_empty @ext.extensions, "sanity check" @@ -1426,7 +1423,6 @@ dependencies: [] end def test_build_extensions_error - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec refute_empty @ext.extensions, "sanity check" @@ -1440,7 +1436,7 @@ dependencies: [] pend "chmod not supported" if Gem.win_platform? pend "skipped in root privilege" if Process.uid.zero? - pend "extensions don't quite work on jruby" if Gem.java_platform? + pend "needs investigation" if Gem.java_platform? ext_spec refute_empty @ext.extensions, "sanity check" @@ -1473,7 +1469,6 @@ dependencies: [] def test_build_extensions_no_extensions_dir_unwritable pend "chmod not supported" if Gem.win_platform? - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec refute_empty @ext.extensions, "sanity check" @@ -1512,7 +1507,6 @@ dependencies: [] end def test_build_extensions_preview - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec extconf_rb = File.join @ext.gem_dir, @ext.extensions.first @@ -1547,7 +1541,6 @@ dependencies: [] end def test_contains_requirable_file_eh_extension - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec _, err = capture_output do @@ -3843,7 +3836,6 @@ end end def test_missing_extensions_eh - pend "extensions don't quite work on jruby" if Gem.java_platform? ext_spec assert @ext.missing_extensions? diff --git a/test/rubygems/test_gem_stub_specification.rb b/test/rubygems/test_gem_stub_specification.rb index fe30a78c0b..50321ffd7c 100644 --- a/test/rubygems/test_gem_stub_specification.rb +++ b/test/rubygems/test_gem_stub_specification.rb @@ -66,7 +66,6 @@ class TestStubSpecification < Gem::TestCase end def test_contains_requirable_file_eh_extension - pend "I guess making the stub match the running platform should work" if Gem.java_platform? stub_with_extension do |stub| _, err = capture_output do refute stub.contains_requirable_file? "nonexistent" @@ -123,7 +122,6 @@ class TestStubSpecification < Gem::TestCase end def test_missing_extensions_eh - pend "I guess making the stub match the running platform should work" if Gem.java_platform? stub = stub_with_extension do |s| extconf_rb = File.join s.gem_dir, s.extensions.first FileUtils.mkdir_p File.dirname extconf_rb diff --git a/test/rubygems/test_require.rb b/test/rubygems/test_require.rb index f15e9b6243..f63c23c315 100644 --- a/test/rubygems/test_require.rb +++ b/test/rubygems/test_require.rb @@ -130,7 +130,7 @@ class TestGemRequire < Gem::TestCase end def test_dash_i_respects_default_library_extension_priority - pend "extensions don't quite work on jruby" if Gem.java_platform? + pend "needs investigation" if Gem.java_platform? pend "not installed yet" unless RbConfig::TOPDIR dash_i_ext_arg = util_install_extension_file("a")