1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QMac{,RootLevel}AutoReleasePool: mark ctors [[nodiscard]]

Browse Source 
They're RAII classes, and QUIP-0019 says RAII class' constructors
should be marked [[nodiscard]].

Pick-to: 6.6
Task-number: QTBUG-104164
Change-Id: I0080f5b6a3cea346c0860e00958a8c204849040e
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
This commit is contained in:
Marc Mutz 2023-06-13 09:34:12 +02:00
parent 2a76cf8181
commit ffed431293
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/corelib/kernel/qcore_mac_p.h
View File

@ -112,7 +112,7 @@ protected:
class QMacAutoReleasePool class QMacAutoReleasePool
{ {
public: public:
Q_CORE_EXPORT QMacAutoReleasePool(); Q_NODISCARD_CTOR Q_CORE_EXPORT QMacAutoReleasePool();
Q_CORE_EXPORT ~QMacAutoReleasePool(); Q_CORE_EXPORT ~QMacAutoReleasePool();
private: private:
Q_DISABLE_COPY(QMacAutoReleasePool) Q_DISABLE_COPY(QMacAutoReleasePool)
@ -123,7 +123,7 @@ private:
class QMacRootLevelAutoReleasePool class QMacRootLevelAutoReleasePool
{ {
public: public:
QMacRootLevelAutoReleasePool(); Q_NODISCARD_CTOR QMacRootLevelAutoReleasePool();
~QMacRootLevelAutoReleasePool(); ~QMacRootLevelAutoReleasePool();
private: private:
QScopedPointer<QMacAutoReleasePool> pool; QScopedPointer<QMacAutoReleasePool> pool;