From ffed431293cb0fcb85bdda2e1c4db9bda79a00fc Mon Sep 17 00:00:00 2001
From: Marc Mutz <marc.mutz@qt.io>
Date: Tue, 13 Jun 2023 09:34:12 +0200
Subject: [PATCH] QMac{,RootLevel}AutoReleasePool: mark ctors [[nodiscard]]
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

They're RAII classes, and QUIP-0019 says RAII class' constructors
should be marked [[nodiscard]].

Pick-to: 6.6
Task-number: QTBUG-104164
Change-Id: I0080f5b6a3cea346c0860e00958a8c204849040e
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
---
 src/corelib/kernel/qcore_mac_p.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/corelib/kernel/qcore_mac_p.h b/src/corelib/kernel/qcore_mac_p.h
index 8764171383c..502b9746be4 100644
--- a/src/corelib/kernel/qcore_mac_p.h
+++ b/src/corelib/kernel/qcore_mac_p.h
@@ -112,7 +112,7 @@ protected:
 class QMacAutoReleasePool
 {
 public:
-    Q_CORE_EXPORT QMacAutoReleasePool();
+    Q_NODISCARD_CTOR Q_CORE_EXPORT QMacAutoReleasePool();
     Q_CORE_EXPORT ~QMacAutoReleasePool();
 private:
     Q_DISABLE_COPY(QMacAutoReleasePool)
@@ -123,7 +123,7 @@ private:
 class QMacRootLevelAutoReleasePool
 {
 public:
-    QMacRootLevelAutoReleasePool();
+    Q_NODISCARD_CTOR QMacRootLevelAutoReleasePool();
     ~QMacRootLevelAutoReleasePool();
 private:
     QScopedPointer<QMacAutoReleasePool> pool;