1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QH2Expected: use Rule Of Zero

Browse Source 
It doesn't always pay to be explicit about SMFs. In the present case,
clang-tidy complains that the move ctors of the class aren't
noexcept. It's a false positive, but just removing all the =default'ed
SMFs makes it go away, too.

Amends 0dba3f6b713a657eb3bf2037face72d16253eb92.

Change-Id: Ib641d4eed9e214b41c143b60494e82790da6fda8
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit fab57c25e22239516dec737f2d42a7fccae9d37f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2024-01-18 09:32:00 +01:00 committed by Qt Cherry-pick Bot
parent ecfdb8b180
commit e5d1c778ad
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/network/access/qhttp2connection_p.h
View File

@ -40,15 +40,11 @@ class QH2Expected
{
static_assert(!std::is_same_v<T, Err>, "T and Err must be different types");
public:
// Rule Of Zero applies
QH2Expected(T &&value) : m_data(std::move(value)) { }
QH2Expected(const T &value) : m_data(value) { }
QH2Expected(Err &&error) : m_data(std::move(error)) { }
QH2Expected(const Err &error) : m_data(error) { }
QH2Expected(const QH2Expected &) = default;
QH2Expected(QH2Expected &&) = default;
QH2Expected &operator=(const QH2Expected &) = default;
QH2Expected &operator=(QH2Expected &&) = default;
~QH2Expected() = default;
QH2Expected &operator=(T &&value)
{