From e5d1c778ada1fde613c16e5d7bdcf7be9341237a Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 18 Jan 2024 09:32:00 +0100 Subject: [PATCH] QH2Expected: use Rule Of Zero MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It doesn't always pay to be explicit about SMFs. In the present case, clang-tidy complains that the move ctors of the class aren't noexcept. It's a false positive, but just removing all the =default'ed SMFs makes it go away, too. Amends 0dba3f6b713a657eb3bf2037face72d16253eb92. Change-Id: Ib641d4eed9e214b41c143b60494e82790da6fda8 Reviewed-by: Volker Hilsheimer Reviewed-by: Mårten Nordheim (cherry picked from commit fab57c25e22239516dec737f2d42a7fccae9d37f) Reviewed-by: Qt Cherry-pick Bot --- src/network/access/qhttp2connection_p.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/network/access/qhttp2connection_p.h b/src/network/access/qhttp2connection_p.h index 8e6bc52fc03..7ca303f0a8c 100644 --- a/src/network/access/qhttp2connection_p.h +++ b/src/network/access/qhttp2connection_p.h @@ -40,15 +40,11 @@ class QH2Expected { static_assert(!std::is_same_v, "T and Err must be different types"); public: + // Rule Of Zero applies QH2Expected(T &&value) : m_data(std::move(value)) { } QH2Expected(const T &value) : m_data(value) { } QH2Expected(Err &&error) : m_data(std::move(error)) { } QH2Expected(const Err &error) : m_data(error) { } - QH2Expected(const QH2Expected &) = default; - QH2Expected(QH2Expected &&) = default; - QH2Expected &operator=(const QH2Expected &) = default; - QH2Expected &operator=(QH2Expected &&) = default; - ~QH2Expected() = default; QH2Expected &operator=(T &&value) {