1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QStringList: improve benchmark code

Browse Source 
Make the strings in the stringlist-to-be-joined unique, which matches
actual use-cases better than joining a list of identical strings,
especially with QString's implicit sharing, if it's copies of the same
QString, it's sharing the underlying data.

Pick-to: 6.6 6.5 6.2 5.15
Task-number: QTBUG-116859
Change-Id: I1da93885e938045322ba8337df5e4e96985f892f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Ahmad Samir 2023-04-08 13:38:49 +02:00
parent a86fda6423
commit e1dcc858b2
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/benchmarks/corelib/text/qstringlist/tst_bench_qstringlist.cpp
View File

@ -49,7 +49,12 @@ private:
QStringList tst_QStringList::populateList(const int count, const QString &unit) QStringList tst_QStringList::populateList(const int count, const QString &unit)
{ {
return QStringList(count, unit); QStringList retval;
retval.reserve(count);
for (int i = 0; i < count; ++i)
retval.append(unit + QString::number(i));
return retval;
} }
QString tst_QStringList::populateString(const int count, const QString &unit) QString tst_QStringList::populateString(const int count, const QString &unit)
@ -79,20 +84,20 @@ void tst_QStringList::join_data() const
QTest::addColumn<QStringList>("input"); QTest::addColumn<QStringList>("input");
QTest::addColumn<QString>("separator"); QTest::addColumn<QString>("separator");
QTest::newRow("") QTest::newRow("100")
<< populateList(100, QLatin1String("unit")) << populateList(100, QLatin1String("unit"))
<< QString(); << QString();
QTest::newRow("") QTest::newRow("1000")
<< populateList(1000, QLatin1String("unit")) << populateList(1000, QLatin1String("unit"))
<< QString(); << QString();
QTest::newRow("") QTest::newRow("10000")
<< populateList(10000, QLatin1String("unit")) << populateList(10'000, QLatin1String("unit"))
<< QString(); << QString();
QTest::newRow("") QTest::newRow("100000")
<< populateList(100000, QLatin1String("unit")) << populateList(100'000, QLatin1String("unit"))
<< QString(); << QString();
} }