From e1dcc858b2a0ac2b359cdbf7e07e70c1237daef0 Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Sat, 8 Apr 2023 13:38:49 +0200 Subject: [PATCH] QStringList: improve benchmark code Make the strings in the stringlist-to-be-joined unique, which matches actual use-cases better than joining a list of identical strings, especially with QString's implicit sharing, if it's copies of the same QString, it's sharing the underlying data. Pick-to: 6.6 6.5 6.2 5.15 Task-number: QTBUG-116859 Change-Id: I1da93885e938045322ba8337df5e4e96985f892f Reviewed-by: Thiago Macieira --- .../qstringlist/tst_bench_qstringlist.cpp | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/tests/benchmarks/corelib/text/qstringlist/tst_bench_qstringlist.cpp b/tests/benchmarks/corelib/text/qstringlist/tst_bench_qstringlist.cpp index fae879ce373..dc3699aad68 100644 --- a/tests/benchmarks/corelib/text/qstringlist/tst_bench_qstringlist.cpp +++ b/tests/benchmarks/corelib/text/qstringlist/tst_bench_qstringlist.cpp @@ -49,7 +49,12 @@ private: QStringList tst_QStringList::populateList(const int count, const QString &unit) { - return QStringList(count, unit); + QStringList retval; + retval.reserve(count); + for (int i = 0; i < count; ++i) + retval.append(unit + QString::number(i)); + + return retval; } QString tst_QStringList::populateString(const int count, const QString &unit) @@ -79,20 +84,20 @@ void tst_QStringList::join_data() const QTest::addColumn("input"); QTest::addColumn("separator"); - QTest::newRow("") + QTest::newRow("100") << populateList(100, QLatin1String("unit")) << QString(); - QTest::newRow("") + QTest::newRow("1000") << populateList(1000, QLatin1String("unit")) << QString(); - QTest::newRow("") - << populateList(10000, QLatin1String("unit")) + QTest::newRow("10000") + << populateList(10'000, QLatin1String("unit")) << QString(); - QTest::newRow("") - << populateList(100000, QLatin1String("unit")) + QTest::newRow("100000") + << populateList(100'000, QLatin1String("unit")) << QString(); }