1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass PrefixTable and PrefixTableEntry by value

Browse Source 
Small, trivially copyable and trivially destructible types should be
passed by value.

Found by an Axivion Scan.

Task-number: QTBUG-125026
Pick-to: 6.7 6.5
Change-Id: I870b276a22dca55eac9afac8713cc81bf8ddcf32
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
(cherry picked from commit f6e964d0f67b0f1324986fb63a23cbbac78dc503)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Mate Barany 2024-09-02 16:21:55 +02:00 committed by Qt Cherry-pick Bot
parent 1b22ef4a35
commit e11a957678
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/network/access/http2/huffman.cpp
View File

@ -514,14 +514,14 @@ quint32 HuffmanDecoder::addTable(quint32 prefix, quint32 index)
return quint32(prefixTables.size() - 1);
}
PrefixTableEntry HuffmanDecoder::tableEntry(const PrefixTable &table, quint32 index)
PrefixTableEntry HuffmanDecoder::tableEntry(PrefixTable table, quint32 index)
{
Q_ASSERT(index < table.size());
return tableData[table.offset + index];
}
void HuffmanDecoder::setTableEntry(const PrefixTable &table, quint32 index,
const PrefixTableEntry &entry)
void HuffmanDecoder::setTableEntry(PrefixTable table, quint32 index,
PrefixTableEntry entry)
{
Q_ASSERT(index < table.size());
tableData[table.offset + index] = entry;

4
src/network/access/http2/huffman_p.h
View File

@ -115,8 +115,8 @@ public:
private:
quint32 addTable(quint32 prefixLength, quint32 indexLength);
PrefixTableEntry tableEntry(const PrefixTable &table, quint32 index);
void setTableEntry(const PrefixTable &table, quint32 index, const PrefixTableEntry &entry);
PrefixTableEntry tableEntry(PrefixTable table, quint32 index);
void setTableEntry(PrefixTable table, quint32 index, PrefixTableEntry entry);
std::vector<PrefixTable> prefixTables;
std::vector<PrefixTableEntry> tableData;