From e11a957678ed81835fe05b48ee15324a7fa38b02 Mon Sep 17 00:00:00 2001
From: Mate Barany <mate.barany@qt.io>
Date: Mon, 2 Sep 2024 16:21:55 +0200
Subject: [PATCH] Pass PrefixTable and PrefixTableEntry by value
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Small, trivially copyable and trivially destructible types should be
passed by value.

Found by an Axivion Scan.

Task-number: QTBUG-125026
Pick-to: 6.7 6.5
Change-Id: I870b276a22dca55eac9afac8713cc81bf8ddcf32
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
(cherry picked from commit f6e964d0f67b0f1324986fb63a23cbbac78dc503)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/network/access/http2/huffman.cpp | 6 +++---
 src/network/access/http2/huffman_p.h | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/network/access/http2/huffman.cpp b/src/network/access/http2/huffman.cpp
index f5b6cd2ebed..8d7cee715a1 100644
--- a/src/network/access/http2/huffman.cpp
+++ b/src/network/access/http2/huffman.cpp
@@ -514,14 +514,14 @@ quint32 HuffmanDecoder::addTable(quint32 prefix, quint32 index)
     return quint32(prefixTables.size() - 1);
 }
 
-PrefixTableEntry HuffmanDecoder::tableEntry(const PrefixTable &table, quint32 index)
+PrefixTableEntry HuffmanDecoder::tableEntry(PrefixTable table, quint32 index)
 {
     Q_ASSERT(index < table.size());
     return tableData[table.offset + index];
 }
 
-void HuffmanDecoder::setTableEntry(const PrefixTable &table, quint32 index,
-                                   const PrefixTableEntry &entry)
+void HuffmanDecoder::setTableEntry(PrefixTable table, quint32 index,
+                                   PrefixTableEntry entry)
 {
     Q_ASSERT(index < table.size());
     tableData[table.offset + index] = entry;
diff --git a/src/network/access/http2/huffman_p.h b/src/network/access/http2/huffman_p.h
index daa2b31bb3f..813b0dfe870 100644
--- a/src/network/access/http2/huffman_p.h
+++ b/src/network/access/http2/huffman_p.h
@@ -115,8 +115,8 @@ public:
 
 private:
     quint32 addTable(quint32 prefixLength, quint32 indexLength);
-    PrefixTableEntry tableEntry(const PrefixTable &table, quint32 index);
-    void setTableEntry(const PrefixTable &table, quint32 index, const PrefixTableEntry &entry);
+    PrefixTableEntry tableEntry(PrefixTable table, quint32 index);
+    void setTableEntry(PrefixTable table, quint32 index, PrefixTableEntry entry);
 
     std::vector<PrefixTable> prefixTables;
     std::vector<PrefixTableEntry> tableData;