1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MinGW compile fix: Add missing inline keyword

Browse Source 
Some compilers are picky about that the declaration needs to match the
definition also for the inline keyword:

qt5/qtbase/src/corelib/io/qfilesystemmetadata_p.h:239:27: error:
'QFileDevice::Permissions QFileSystemMetaData::permissions() const' redeclared
without dllimport attribute after being referenced with dll linkage [-Werror]
  239 | inline QFile::Permissions QFileSystemMetaData::permissions()...
      |                           ^~~~~~~~~~~~~~~~~~~
cc1plus.exe: all warnings being treated as errors

Fix by declaring the function inline, not only at the definition.

Change-Id: I68d1fd2f9952ec3bf54b1ba27461bf1751c9d301
Reviewed-by: Matthias Rauter <matthias.rauter@qt.io>
(cherry picked from commit b950ec2525af789b3d447218ae62906c2f78f5a5)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Jan Arve Sæther 2024-06-27 10:03:04 +02:00 committed by Qt Cherry-pick Bot
parent 954e7b623b
commit cfc50c7026
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/io/qfilesystemmetadata_p.h
View File

@ -179,7 +179,7 @@ public:
qint64 size() const { return size_; }
QFile::Permissions permissions() const;
inline QFile::Permissions permissions() const;
QDateTime accessTime() const;
QDateTime birthTime() const;