From cfc50c7026d6eb5b54cc5490cca26d82d7ede52b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Arve=20S=C3=A6ther?= Date: Thu, 27 Jun 2024 10:03:04 +0200 Subject: [PATCH] MinGW compile fix: Add missing inline keyword Some compilers are picky about that the declaration needs to match the definition also for the inline keyword: qt5/qtbase/src/corelib/io/qfilesystemmetadata_p.h:239:27: error: 'QFileDevice::Permissions QFileSystemMetaData::permissions() const' redeclared without dllimport attribute after being referenced with dll linkage [-Werror] 239 | inline QFile::Permissions QFileSystemMetaData::permissions()... | ^~~~~~~~~~~~~~~~~~~ cc1plus.exe: all warnings being treated as errors Fix by declaring the function inline, not only at the definition. Change-Id: I68d1fd2f9952ec3bf54b1ba27461bf1751c9d301 Reviewed-by: Matthias Rauter (cherry picked from commit b950ec2525af789b3d447218ae62906c2f78f5a5) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/io/qfilesystemmetadata_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/io/qfilesystemmetadata_p.h b/src/corelib/io/qfilesystemmetadata_p.h index c10b66afaf7..12aebdd7079 100644 --- a/src/corelib/io/qfilesystemmetadata_p.h +++ b/src/corelib/io/qfilesystemmetadata_p.h @@ -179,7 +179,7 @@ public: qint64 size() const { return size_; } - QFile::Permissions permissions() const; + inline QFile::Permissions permissions() const; QDateTime accessTime() const; QDateTime birthTime() const;