1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QPromise: remove some unneeded mutable from lambdas

Browse Source 
Lambdas that only capture by reference never need to be mutable.

Drop the keyword (and the now-superfluous parentheses).

Amends 385f0732d927f0eba8ecf990ee9bc19936475edd.

Pick-to: 6.5 6.2
Change-Id: Iaa6451c1c26f1aed198c447ee59198c4e0285b15
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit 37daf732d5089c58a6428124263243509d152987)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2024-11-01 08:53:36 +01:00 committed by Qt Cherry-pick Bot
parent 9e99f2a977
commit c6e13deab6
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/auto/corelib/thread/qpromise/tst_qpromise.cpp
View File

@ -413,9 +413,9 @@ void tst_QPromise::reportFromMultipleThreads()
promise.start();
ThreadWrapper threads[] = {
ThreadWrapper([&promise] () mutable { promise.addResult(42); }),
ThreadWrapper([&promise] () mutable { promise.addResult(43); }),
ThreadWrapper([&promise] () mutable { promise.addResult(44); }),
ThreadWrapper([&promise] { promise.addResult(42); }),
ThreadWrapper([&promise] { promise.addResult(43); }),
ThreadWrapper([&promise] { promise.addResult(44); }),
};
for (auto& t : threads)
t.join();
@ -441,9 +441,9 @@ void tst_QPromise::reportFromMultipleThreadsByMovedPromise()
auto promise = std::move(initialPromise);
promise.start();
ThreadWrapper threads[] = {
ThreadWrapper([&promise] () mutable { promise.addResult(42); }),
ThreadWrapper([&promise] () mutable { promise.addResult(43); }),
ThreadWrapper([&promise] () mutable { promise.addResult(44); }),
ThreadWrapper([&promise] { promise.addResult(42); }),
ThreadWrapper([&promise] { promise.addResult(43); }),
ThreadWrapper([&promise] { promise.addResult(44); }),
};
for (auto& t : threads)
t.join();
@ -497,9 +497,9 @@ void tst_QPromise::cancelWhenDestroyed()
auto promise = std::move(initialPromise);
promise.start();
ThreadWrapper threads[] = {
ThreadWrapper([&promise] () mutable { promise.addResult(42); }),
ThreadWrapper([&promise] () mutable { promise.addResult(43); }),
ThreadWrapper([&promise] () mutable { promise.addResult(44); }),
ThreadWrapper([&promise] { promise.addResult(42); }),
ThreadWrapper([&promise] { promise.addResult(43); }),
ThreadWrapper([&promise] { promise.addResult(44); }),
};
for (auto& t : threads)
t.join();