From c6e13deab6c0547df7ae2976fd4b39252119b6f8 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Fri, 1 Nov 2024 08:53:36 +0100 Subject: [PATCH] tst_QPromise: remove some unneeded mutable from lambdas MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Lambdas that only capture by reference never need to be mutable. Drop the keyword (and the now-superfluous parentheses). Amends 385f0732d927f0eba8ecf990ee9bc19936475edd. Pick-to: 6.5 6.2 Change-Id: Iaa6451c1c26f1aed198c447ee59198c4e0285b15 Reviewed-by: Mårten Nordheim (cherry picked from commit 37daf732d5089c58a6428124263243509d152987) Reviewed-by: Qt Cherry-pick Bot --- .../corelib/thread/qpromise/tst_qpromise.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/auto/corelib/thread/qpromise/tst_qpromise.cpp b/tests/auto/corelib/thread/qpromise/tst_qpromise.cpp index 505ee6d3a42..ad7bcea60b3 100644 --- a/tests/auto/corelib/thread/qpromise/tst_qpromise.cpp +++ b/tests/auto/corelib/thread/qpromise/tst_qpromise.cpp @@ -413,9 +413,9 @@ void tst_QPromise::reportFromMultipleThreads() promise.start(); ThreadWrapper threads[] = { - ThreadWrapper([&promise] () mutable { promise.addResult(42); }), - ThreadWrapper([&promise] () mutable { promise.addResult(43); }), - ThreadWrapper([&promise] () mutable { promise.addResult(44); }), + ThreadWrapper([&promise] { promise.addResult(42); }), + ThreadWrapper([&promise] { promise.addResult(43); }), + ThreadWrapper([&promise] { promise.addResult(44); }), }; for (auto& t : threads) t.join(); @@ -441,9 +441,9 @@ void tst_QPromise::reportFromMultipleThreadsByMovedPromise() auto promise = std::move(initialPromise); promise.start(); ThreadWrapper threads[] = { - ThreadWrapper([&promise] () mutable { promise.addResult(42); }), - ThreadWrapper([&promise] () mutable { promise.addResult(43); }), - ThreadWrapper([&promise] () mutable { promise.addResult(44); }), + ThreadWrapper([&promise] { promise.addResult(42); }), + ThreadWrapper([&promise] { promise.addResult(43); }), + ThreadWrapper([&promise] { promise.addResult(44); }), }; for (auto& t : threads) t.join(); @@ -497,9 +497,9 @@ void tst_QPromise::cancelWhenDestroyed() auto promise = std::move(initialPromise); promise.start(); ThreadWrapper threads[] = { - ThreadWrapper([&promise] () mutable { promise.addResult(42); }), - ThreadWrapper([&promise] () mutable { promise.addResult(43); }), - ThreadWrapper([&promise] () mutable { promise.addResult(44); }), + ThreadWrapper([&promise] { promise.addResult(42); }), + ThreadWrapper([&promise] { promise.addResult(43); }), + ThreadWrapper([&promise] { promise.addResult(44); }), }; for (auto& t : threads) t.join();