1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leaks in tst_qlineedit

Browse Source 
In the unit tests, two times a validator was used without a parent,
which led to memory leaks. This patch changes this: The
validators are initialized with the widget they are meant for
as parent. This fixes the memory leaks.

Pick-to: 6.2
Change-Id: I480c0c5104cbe60159fad49df28cbb6240e7ce68
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Ievgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io>
This commit is contained in:
Andreas Buhr 2021-07-06 14:08:28 +02:00
parent eaa48136a3
commit b854bf06dc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp
View File

@ -3322,7 +3322,7 @@ void tst_QLineEdit::validateOnFocusOut()
QLineEdit *testWidget = ensureTestWidget(); QLineEdit *testWidget = ensureTestWidget();
QSignalSpy editingFinishedSpy(testWidget, SIGNAL(editingFinished())); QSignalSpy editingFinishedSpy(testWidget, SIGNAL(editingFinished()));
testWidget->setValidator(new QIntValidator(100, 999, 0)); testWidget->setValidator(new QIntValidator(100, 999, testWidget));
QTest::keyPress(testWidget, '1'); QTest::keyPress(testWidget, '1');
QTest::keyPress(testWidget, '0'); QTest::keyPress(testWidget, '0');
QCOMPARE(testWidget->text(), QString("10")); QCOMPARE(testWidget->text(), QString("10"));
@ -3347,7 +3347,7 @@ void tst_QLineEdit::editInvalidText()
{ {
QLineEdit *testWidget = ensureTestWidget(); QLineEdit *testWidget = ensureTestWidget();
testWidget->clear(); testWidget->clear();
testWidget->setValidator(new QIntValidator(0, 12, 0)); testWidget->setValidator(new QIntValidator(0, 12, testWidget));
testWidget->setText("1234"); testWidget->setText("1234");
QVERIFY(!testWidget->hasAcceptableInput()); QVERIFY(!testWidget->hasAcceptableInput());