From b854bf06dc1902b101c2622f519c84a2a93e2fb1 Mon Sep 17 00:00:00 2001 From: Andreas Buhr Date: Tue, 6 Jul 2021 14:08:28 +0200 Subject: [PATCH] Fix memory leaks in tst_qlineedit In the unit tests, two times a validator was used without a parent, which led to memory leaks. This patch changes this: The validators are initialized with the widget they are meant for as parent. This fixes the memory leaks. Pick-to: 6.2 Change-Id: I480c0c5104cbe60159fad49df28cbb6240e7ce68 Reviewed-by: Edward Welbourne Reviewed-by: Ievgenii Meshcheriakov --- tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp b/tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp index 8668dfb8e22..99344228b68 100644 --- a/tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp +++ b/tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp @@ -3322,7 +3322,7 @@ void tst_QLineEdit::validateOnFocusOut() QLineEdit *testWidget = ensureTestWidget(); QSignalSpy editingFinishedSpy(testWidget, SIGNAL(editingFinished())); - testWidget->setValidator(new QIntValidator(100, 999, 0)); + testWidget->setValidator(new QIntValidator(100, 999, testWidget)); QTest::keyPress(testWidget, '1'); QTest::keyPress(testWidget, '0'); QCOMPARE(testWidget->text(), QString("10")); @@ -3347,7 +3347,7 @@ void tst_QLineEdit::editInvalidText() { QLineEdit *testWidget = ensureTestWidget(); testWidget->clear(); - testWidget->setValidator(new QIntValidator(0, 12, 0)); + testWidget->setValidator(new QIntValidator(0, 12, testWidget)); testWidget->setText("1234"); QVERIFY(!testWidget->hasAcceptableInput());