1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QNetworkInformation: Actually compare names case insensitively

Browse Source 
The docs (10 lines above) say it will find the backend case
insensitively. Thus the comparison should also be case-insensitive.

Change-Id: I65901ed81b7d8bdfcf76f5b6c7b40efe63245503
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit 810e4e56bdf958a16723cef19cbfd1aa2ba6e942)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Mårten Nordheim 2021-09-17 16:01:21 +02:00 committed by Qt Cherry-pick Bot
parent 31909e2052
commit b11473fca2
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/kernel/qnetworkinformation.cpp
View File

@ -556,7 +556,7 @@ bool QNetworkInformation::supports(Features features) const
bool QNetworkInformation::load(QStringView backend) bool QNetworkInformation::load(QStringView backend)
{ {
auto loadedBackend = QNetworkInformationPrivate::create(backend); auto loadedBackend = QNetworkInformationPrivate::create(backend);
return loadedBackend && loadedBackend->backendName() == backend; return loadedBackend && loadedBackend->backendName().compare(backend, Qt::CaseInsensitive) == 0;
} }
/*! /*!

1
tests/auto/network/kernel/qnetworkinformation/tst_qnetworkinformation.cpp
View File

@ -119,6 +119,7 @@ void tst_QNetworkInformation::initTestCase()
QVERIFY(backends.contains(u"mock")); QVERIFY(backends.contains(u"mock"));
QVERIFY(QNetworkInformation::load(u"mock")); QVERIFY(QNetworkInformation::load(u"mock"));
QVERIFY(QNetworkInformation::load(u"mock")); QVERIFY(QNetworkInformation::load(u"mock"));
QVERIFY(QNetworkInformation::load(u"mOcK"));
QVERIFY(!QNetworkInformation::load(u"mocks")); QVERIFY(!QNetworkInformation::load(u"mocks"));
} }