From b11473fca258c0bb89dce20d2f3a555fd9b880ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Fri, 17 Sep 2021 16:01:21 +0200 Subject: [PATCH] QNetworkInformation: Actually compare names case insensitively The docs (10 lines above) say it will find the backend case insensitively. Thus the comparison should also be case-insensitive. Change-Id: I65901ed81b7d8bdfcf76f5b6c7b40efe63245503 Reviewed-by: Edward Welbourne (cherry picked from commit 810e4e56bdf958a16723cef19cbfd1aa2ba6e942) Reviewed-by: Qt Cherry-pick Bot --- src/network/kernel/qnetworkinformation.cpp | 2 +- .../kernel/qnetworkinformation/tst_qnetworkinformation.cpp | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/network/kernel/qnetworkinformation.cpp b/src/network/kernel/qnetworkinformation.cpp index 82dee811d28..56ffe15cbf0 100644 --- a/src/network/kernel/qnetworkinformation.cpp +++ b/src/network/kernel/qnetworkinformation.cpp @@ -556,7 +556,7 @@ bool QNetworkInformation::supports(Features features) const bool QNetworkInformation::load(QStringView backend) { auto loadedBackend = QNetworkInformationPrivate::create(backend); - return loadedBackend && loadedBackend->backendName() == backend; + return loadedBackend && loadedBackend->backendName().compare(backend, Qt::CaseInsensitive) == 0; } /*! diff --git a/tests/auto/network/kernel/qnetworkinformation/tst_qnetworkinformation.cpp b/tests/auto/network/kernel/qnetworkinformation/tst_qnetworkinformation.cpp index 92dba1e7c1c..2795def73df 100644 --- a/tests/auto/network/kernel/qnetworkinformation/tst_qnetworkinformation.cpp +++ b/tests/auto/network/kernel/qnetworkinformation/tst_qnetworkinformation.cpp @@ -119,6 +119,7 @@ void tst_QNetworkInformation::initTestCase() QVERIFY(backends.contains(u"mock")); QVERIFY(QNetworkInformation::load(u"mock")); QVERIFY(QNetworkInformation::load(u"mock")); + QVERIFY(QNetworkInformation::load(u"mOcK")); QVERIFY(!QNetworkInformation::load(u"mocks")); }