Rename the replace() function's value to newValue to reflect its role
Found in API-review Change-Id: Ib047c79d977ad6870c1e426cd1add994a3634df4 Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit 723ab99b1ac55c8d32a93ea80224d7ffb22f7893) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
parent
a18964adf0
commit
a1cc252130
@ -870,7 +870,7 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu
|
||||
}
|
||||
|
||||
/*!
|
||||
Replaces the header entry at index \a i, with \a name and \a value.
|
||||
Replaces the header entry at index \a i, with \a name and \a newValue.
|
||||
The index must be valid (see \l size()). Returns whether the replace
|
||||
succeeded.
|
||||
|
||||
@ -878,28 +878,28 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu
|
||||
replace(qsizetype, QHttpHeaders::WellKnownHeader, QAnyStringView), size()
|
||||
\sa {Allowed field name and value characters}
|
||||
*/
|
||||
bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView value)
|
||||
bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView newValue)
|
||||
{
|
||||
d->verify(i);
|
||||
if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(value))
|
||||
if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(newValue))
|
||||
return false;
|
||||
|
||||
d.detach();
|
||||
d->headers.replace(i, {normalizedName(name), normalizedValue(value)});
|
||||
d->headers.replace(i, {normalizedName(name), normalizedValue(newValue)});
|
||||
return true;
|
||||
}
|
||||
|
||||
/*!
|
||||
\overload replace(qsizetype, QAnyStringView, QAnyStringView)
|
||||
*/
|
||||
bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView value)
|
||||
bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue)
|
||||
{
|
||||
d->verify(i);
|
||||
if (!isValidHttpHeaderValueField(value))
|
||||
if (!isValidHttpHeaderValueField(newValue))
|
||||
return false;
|
||||
|
||||
d.detach();
|
||||
d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(value)});
|
||||
d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(newValue)});
|
||||
return true;
|
||||
}
|
||||
|
||||
|
@ -224,8 +224,8 @@ public:
|
||||
Q_NETWORK_EXPORT bool insert(qsizetype i, QAnyStringView name, QAnyStringView value);
|
||||
Q_NETWORK_EXPORT bool insert(qsizetype i, WellKnownHeader name, QAnyStringView value);
|
||||
|
||||
Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView value);
|
||||
Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView value);
|
||||
Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView newValue);
|
||||
Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue);
|
||||
|
||||
Q_NETWORK_EXPORT bool has(QAnyStringView name) const;
|
||||
Q_NETWORK_EXPORT bool has(WellKnownHeader name) const;
|
||||
|
Loading…
x
Reference in New Issue
Block a user