From a1cc25213084c8d029dd97fb4a710644db14dd2f Mon Sep 17 00:00:00 2001 From: Juha Vuolle Date: Wed, 10 Jan 2024 14:23:49 +0200 Subject: [PATCH] Rename the replace() function's value to newValue to reflect its role Found in API-review Change-Id: Ib047c79d977ad6870c1e426cd1add994a3634df4 Reviewed-by: Ivan Solovev Reviewed-by: Marc Mutz (cherry picked from commit 723ab99b1ac55c8d32a93ea80224d7ffb22f7893) Reviewed-by: Qt Cherry-pick Bot --- src/network/access/qhttpheaders.cpp | 14 +++++++------- src/network/access/qhttpheaders.h | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/network/access/qhttpheaders.cpp b/src/network/access/qhttpheaders.cpp index de2f7e148a4..73db0085c15 100644 --- a/src/network/access/qhttpheaders.cpp +++ b/src/network/access/qhttpheaders.cpp @@ -870,7 +870,7 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu } /*! - Replaces the header entry at index \a i, with \a name and \a value. + Replaces the header entry at index \a i, with \a name and \a newValue. The index must be valid (see \l size()). Returns whether the replace succeeded. @@ -878,28 +878,28 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu replace(qsizetype, QHttpHeaders::WellKnownHeader, QAnyStringView), size() \sa {Allowed field name and value characters} */ -bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView value) +bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView newValue) { d->verify(i); - if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(value)) + if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(newValue)) return false; d.detach(); - d->headers.replace(i, {normalizedName(name), normalizedValue(value)}); + d->headers.replace(i, {normalizedName(name), normalizedValue(newValue)}); return true; } /*! \overload replace(qsizetype, QAnyStringView, QAnyStringView) */ -bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView value) +bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue) { d->verify(i); - if (!isValidHttpHeaderValueField(value)) + if (!isValidHttpHeaderValueField(newValue)) return false; d.detach(); - d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(value)}); + d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(newValue)}); return true; } diff --git a/src/network/access/qhttpheaders.h b/src/network/access/qhttpheaders.h index 636f535c88a..df500cfe2e2 100644 --- a/src/network/access/qhttpheaders.h +++ b/src/network/access/qhttpheaders.h @@ -224,8 +224,8 @@ public: Q_NETWORK_EXPORT bool insert(qsizetype i, QAnyStringView name, QAnyStringView value); Q_NETWORK_EXPORT bool insert(qsizetype i, WellKnownHeader name, QAnyStringView value); - Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView value); - Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView value); + Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView newValue); + Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue); Q_NETWORK_EXPORT bool has(QAnyStringView name) const; Q_NETWORK_EXPORT bool has(WellKnownHeader name) const;