1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QDnsLookup: treat NOTIMP replies as server failures

Browse Source 
"Not implemented" is not "invalid reply".

Pick-to: 6.5
Change-Id: I3e3bfef633af4130a03afffd175e2687e7585f36
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Thiago Macieira 2023-05-11 10:21:15 -07:00
parent af9fa21a70
commit 6ac0406464
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/network/kernel/qdnslookup_unix.cpp
View File

@ -107,6 +107,7 @@ void QDnsLookupRunnable::query(const int requestType, const QByteArray &requestN
reply->errorString = tr("Server could not process query");
return;
case SERVFAIL:
case NOTIMP:
reply->error = QDnsLookup::ServerFailureError;
reply->errorString = tr("Server failure");
return;

1
src/network/kernel/qdnslookup_win.cpp
View File

@ -44,6 +44,7 @@ void QDnsLookupRunnable::query(const int requestType, const QByteArray &requestN
reply->errorString = tr("Server could not process query");
return;
case DNS_ERROR_RCODE_SERVER_FAILURE:
case DNS_ERROR_RCODE_NOT_IMPLEMENTED:
reply->error = QDnsLookup::ServerFailureError;
reply->errorString = tr("Server failure");
return;