From 6ac04064649c69824ceec91bb4161d1475238ea0 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 11 May 2023 10:21:15 -0700 Subject: [PATCH] QDnsLookup: treat NOTIMP replies as server failures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "Not implemented" is not "invalid reply". Pick-to: 6.5 Change-Id: I3e3bfef633af4130a03afffd175e2687e7585f36 Reviewed-by: Mårten Nordheim --- src/network/kernel/qdnslookup_unix.cpp | 1 + src/network/kernel/qdnslookup_win.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/network/kernel/qdnslookup_unix.cpp b/src/network/kernel/qdnslookup_unix.cpp index 05e0663aeff..bb1c4feb953 100644 --- a/src/network/kernel/qdnslookup_unix.cpp +++ b/src/network/kernel/qdnslookup_unix.cpp @@ -107,6 +107,7 @@ void QDnsLookupRunnable::query(const int requestType, const QByteArray &requestN reply->errorString = tr("Server could not process query"); return; case SERVFAIL: + case NOTIMP: reply->error = QDnsLookup::ServerFailureError; reply->errorString = tr("Server failure"); return; diff --git a/src/network/kernel/qdnslookup_win.cpp b/src/network/kernel/qdnslookup_win.cpp index 564966e3955..796ff9c2061 100644 --- a/src/network/kernel/qdnslookup_win.cpp +++ b/src/network/kernel/qdnslookup_win.cpp @@ -44,6 +44,7 @@ void QDnsLookupRunnable::query(const int requestType, const QByteArray &requestN reply->errorString = tr("Server could not process query"); return; case DNS_ERROR_RCODE_SERVER_FAILURE: + case DNS_ERROR_RCODE_NOT_IMPLEMENTED: reply->error = QDnsLookup::ServerFailureError; reply->errorString = tr("Server failure"); return;