1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Redundant condition in abstractitemcontainer

Browse Source 
The check to see if m_itemView is empty is already
included in the first condition, and the re-check in
the second condition is unnecessary.
eg: A | | (!A && B) is equivalent to A | | B.

Change-Id: I1a9f003bacea076fc1e72765c196a327a21c33b2
Reviewed-by:  Alexey Edelev <alexey.edelev@qt.io>
(cherry picked from commit 063dad967fbea9649683aa02f457c839e1ab56cb)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tian Shilin 2024-08-22 15:20:37 +08:00 committed by Qt Cherry-pick Bot
parent 9de69c4a99
commit 5ca2e0e48e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/benchmarks/widgets/graphicsview/functional/GraphicsViewBenchmark/widgets/abstractitemcontainer.cpp
View File

@ -211,7 +211,7 @@ bool AbstractItemContainer::itemVisibleInView(AbstractViewItem* item, const QRec
void AbstractItemContainer::updateItemBuffer()
{
if (!m_itemView || (m_itemView && !m_itemView->boundingRect().isValid()))
if (!m_itemView || !m_itemView->boundingRect().isValid())
return;
int maxCount = maxItemCountInItemBuffer();