From 5ca2e0e48e56ae453a8a195ac17c98269b1c9f66 Mon Sep 17 00:00:00 2001 From: Tian Shilin Date: Thu, 22 Aug 2024 15:20:37 +0800 Subject: [PATCH] fix: Redundant condition in abstractitemcontainer The check to see if m_itemView is empty is already included in the first condition, and the re-check in the second condition is unnecessary. eg: A | | (!A && B) is equivalent to A | | B. Change-Id: I1a9f003bacea076fc1e72765c196a327a21c33b2 Reviewed-by: Alexey Edelev (cherry picked from commit 063dad967fbea9649683aa02f457c839e1ab56cb) Reviewed-by: Qt Cherry-pick Bot --- .../GraphicsViewBenchmark/widgets/abstractitemcontainer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/benchmarks/widgets/graphicsview/functional/GraphicsViewBenchmark/widgets/abstractitemcontainer.cpp b/tests/benchmarks/widgets/graphicsview/functional/GraphicsViewBenchmark/widgets/abstractitemcontainer.cpp index 9cf6ffcaa26..e9538bb9f8b 100644 --- a/tests/benchmarks/widgets/graphicsview/functional/GraphicsViewBenchmark/widgets/abstractitemcontainer.cpp +++ b/tests/benchmarks/widgets/graphicsview/functional/GraphicsViewBenchmark/widgets/abstractitemcontainer.cpp @@ -211,7 +211,7 @@ bool AbstractItemContainer::itemVisibleInView(AbstractViewItem* item, const QRec void AbstractItemContainer::updateItemBuffer() { - if (!m_itemView || (m_itemView && !m_itemView->boundingRect().isValid())) + if (!m_itemView || !m_itemView->boundingRect().isValid()) return; int maxCount = maxItemCountInItemBuffer();