1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Undefined Behavior due to delete new[]

Browse Source 
This didn't crash just because a simple type was used.
On other platforms/compilers it may eat your cat or whatever.

Change-Id: Ica2631e4e8ad20ff3a7f4cab60ec8487b6fa70ec
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
This commit is contained in:
Konstantin Ritt 2013-08-10 23:23:43 +03:00 committed by The Qt Project
parent 2af5567f3e
commit 4b0dfef236
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gui/painting/qpaintbuffer.cpp
View File

@ -89,9 +89,9 @@ QTextItemIntCopy::QTextItemIntCopy(const QTextItem &item)
QTextItemIntCopy::~QTextItemIntCopy() QTextItemIntCopy::~QTextItemIntCopy()
{ {
delete m_item.chars; delete [] m_item.chars;
delete m_item.logClusters; delete [] m_item.logClusters;
delete m_item.glyphs.data(); delete [] m_item.glyphs.data();
if (!m_item.fontEngine->ref.deref()) if (!m_item.fontEngine->ref.deref())
delete m_item.fontEngine; delete m_item.fontEngine;
} }