From 4b0dfef236c48dd6f2d629a57cf4d746c9942aeb Mon Sep 17 00:00:00 2001 From: Konstantin Ritt Date: Sat, 10 Aug 2013 23:23:43 +0300 Subject: [PATCH] Fix Undefined Behavior due to `delete new[]` This didn't crash just because a simple type was used. On other platforms/compilers it may eat your cat or whatever. Change-Id: Ica2631e4e8ad20ff3a7f4cab60ec8487b6fa70ec Reviewed-by: Thiago Macieira Reviewed-by: Lars Knoll --- src/gui/painting/qpaintbuffer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gui/painting/qpaintbuffer.cpp b/src/gui/painting/qpaintbuffer.cpp index bb0c441b40f..f855e9e32d2 100644 --- a/src/gui/painting/qpaintbuffer.cpp +++ b/src/gui/painting/qpaintbuffer.cpp @@ -89,9 +89,9 @@ QTextItemIntCopy::QTextItemIntCopy(const QTextItem &item) QTextItemIntCopy::~QTextItemIntCopy() { - delete m_item.chars; - delete m_item.logClusters; - delete m_item.glyphs.data(); + delete [] m_item.chars; + delete [] m_item.logClusters; + delete [] m_item.glyphs.data(); if (!m_item.fontEngine->ref.deref()) delete m_item.fontEngine; }