1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QFileDialog: Use static const QRegularExpression

Browse Source 
This avoids rebuilding the same pattern. Caught by clazy.

Change-Id: Ibd0f2063617df1a9e975f58e34df556d1983afff
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
This commit is contained in:
Waqar Ahmed 2021-08-16 11:56:52 +05:00 committed by Waqar Ahmed
parent 74705ae17b
commit 3c625b7752
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gui/kernel/qplatformdialoghelper.cpp
View File

@ -771,7 +771,7 @@ const char QPlatformFileDialogHelper::filterRegExp[] =
QStringList QPlatformFileDialogHelper::cleanFilterList(const QString &filter) QStringList QPlatformFileDialogHelper::cleanFilterList(const QString &filter)
{ {
#if QT_CONFIG(regularexpression) #if QT_CONFIG(regularexpression)
QRegularExpression regexp(QString::fromLatin1(filterRegExp)); static const QRegularExpression regexp(QString::fromLatin1(filterRegExp));
Q_ASSERT(regexp.isValid()); Q_ASSERT(regexp.isValid());
QString f = filter; QString f = filter;
QRegularExpressionMatch match = regexp.match(filter); QRegularExpressionMatch match = regexp.match(filter);

2
src/widgets/dialogs/qfiledialog.cpp
View File

@ -1375,7 +1375,7 @@ QStringList qt_strip_filters(const QStringList &filters)
{ {
#if QT_CONFIG(regularexpression) #if QT_CONFIG(regularexpression)
QStringList strippedFilters; QStringList strippedFilters;
QRegularExpression r(QString::fromLatin1(QPlatformFileDialogHelper::filterRegExp)); static const QRegularExpression r(QString::fromLatin1(QPlatformFileDialogHelper::filterRegExp));
const int numFilters = filters.count(); const int numFilters = filters.count();
strippedFilters.reserve(numFilters); strippedFilters.reserve(numFilters);
for (int i = 0; i < numFilters; ++i) { for (int i = 0; i < numFilters; ++i) {