From 3c625b77529f1e5348e568b25852a6e5f1f159b0 Mon Sep 17 00:00:00 2001 From: Waqar Ahmed Date: Mon, 16 Aug 2021 11:56:52 +0500 Subject: [PATCH] QFileDialog: Use static const QRegularExpression This avoids rebuilding the same pattern. Caught by clazy. Change-Id: Ibd0f2063617df1a9e975f58e34df556d1983afff Reviewed-by: Richard Moe Gustavsen --- src/gui/kernel/qplatformdialoghelper.cpp | 2 +- src/widgets/dialogs/qfiledialog.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/kernel/qplatformdialoghelper.cpp b/src/gui/kernel/qplatformdialoghelper.cpp index 82b60b77490..9ed2557ad97 100644 --- a/src/gui/kernel/qplatformdialoghelper.cpp +++ b/src/gui/kernel/qplatformdialoghelper.cpp @@ -771,7 +771,7 @@ const char QPlatformFileDialogHelper::filterRegExp[] = QStringList QPlatformFileDialogHelper::cleanFilterList(const QString &filter) { #if QT_CONFIG(regularexpression) - QRegularExpression regexp(QString::fromLatin1(filterRegExp)); + static const QRegularExpression regexp(QString::fromLatin1(filterRegExp)); Q_ASSERT(regexp.isValid()); QString f = filter; QRegularExpressionMatch match = regexp.match(filter); diff --git a/src/widgets/dialogs/qfiledialog.cpp b/src/widgets/dialogs/qfiledialog.cpp index 74484b629d8..8e29609395f 100644 --- a/src/widgets/dialogs/qfiledialog.cpp +++ b/src/widgets/dialogs/qfiledialog.cpp @@ -1375,7 +1375,7 @@ QStringList qt_strip_filters(const QStringList &filters) { #if QT_CONFIG(regularexpression) QStringList strippedFilters; - QRegularExpression r(QString::fromLatin1(QPlatformFileDialogHelper::filterRegExp)); + static const QRegularExpression r(QString::fromLatin1(QPlatformFileDialogHelper::filterRegExp)); const int numFilters = filters.count(); strippedFilters.reserve(numFilters); for (int i = 0; i < numFilters; ++i) {