1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QLocationPermission: make enums have explicit underlying type

Browse Source 
They can be smaller than an int, so use quint8. In a world of BC
guarantees, pinning the underlying type of enums is best practice.

Found during API review.

Change-Id: I0c31fe4565329982c81173e3a265f73758aad257
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit 3b0439379f31aa80bb7a08b2cb17c11311122759)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2023-01-10 13:23:12 +01:00 committed by Qt Cherry-pick Bot
parent 0ec20060bd
commit 3c282ca27c
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/corelib/kernel/qpermissions.h
View File

@ -93,13 +93,19 @@ class QLocationPermission
{
QT_PERMISSION(QLocationPermission)
public:
enum Accuracy { Approximate, Precise };
enum Accuracy : quint8 {
Approximate,
Precise,
};
Q_ENUM(Accuracy)
Q_CORE_EXPORT void setAccuracy(Accuracy accuracy);
Q_CORE_EXPORT Accuracy accuracy() const;
enum Availability { WhenInUse, Always };
enum Availability : quint8 {
WhenInUse,
Always,
};
Q_ENUM(Availability)
Q_CORE_EXPORT void setAvailability(Availability availability);