From 3c282ca27c1e848f2e6e40a1aa43f53b1106fdd0 Mon Sep 17 00:00:00 2001
From: Marc Mutz <marc.mutz@qt.io>
Date: Tue, 10 Jan 2023 13:23:12 +0100
Subject: [PATCH] QLocationPermission: make enums have explicit underlying type
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

They can be smaller than an int, so use quint8. In a world of BC
guarantees, pinning the underlying type of enums is best practice.

Found during API review.

Change-Id: I0c31fe4565329982c81173e3a265f73758aad257
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit 3b0439379f31aa80bb7a08b2cb17c11311122759)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/corelib/kernel/qpermissions.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/corelib/kernel/qpermissions.h b/src/corelib/kernel/qpermissions.h
index 361bc868b68..9c47df3eb17 100644
--- a/src/corelib/kernel/qpermissions.h
+++ b/src/corelib/kernel/qpermissions.h
@@ -93,13 +93,19 @@ class QLocationPermission
 {
     QT_PERMISSION(QLocationPermission)
 public:
-    enum Accuracy { Approximate, Precise };
+    enum Accuracy : quint8 {
+        Approximate,
+        Precise,
+    };
     Q_ENUM(Accuracy)
 
     Q_CORE_EXPORT void setAccuracy(Accuracy accuracy);
     Q_CORE_EXPORT Accuracy accuracy() const;
 
-    enum Availability { WhenInUse, Always };
+    enum Availability : quint8 {
+        WhenInUse,
+        Always,
+    };
     Q_ENUM(Availability)
 
     Q_CORE_EXPORT void setAvailability(Availability availability);