1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TaskTree: Fix some coverity scan issues (use const ref)

Browse Source 
Coverity-Id: 462756 462761 462769 462773
Change-Id: I70db1a0084da78bd1d51aa5bdba94675be5757a4
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
(cherry picked from commit 13fcffa4d658600c8e9d21880e5c617ac3a39106)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Jarek Kobus 2025-05-15 17:48:17 +02:00 committed by Qt Cherry-pick Bot
parent f5faba54d1
commit 27803ba23e
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/assets/downloader/tasking/tasktree.cpp
View File

@ -1869,10 +1869,10 @@ public:
void bumpAsyncCount(); void bumpAsyncCount();
void advanceProgress(int byValue); void advanceProgress(int byValue);
void emitDone(DoneWith result); void emitDone(DoneWith result);
void callSetupHandler(StorageBase storage, StoragePtr storagePtr) { void callSetupHandler(const StorageBase &storage, StoragePtr storagePtr) {
callStorageHandler(storage, storagePtr, &StorageHandler::m_setupHandler); callStorageHandler(storage, storagePtr, &StorageHandler::m_setupHandler);
} }
void callDoneHandler(StorageBase storage, StoragePtr storagePtr) { void callDoneHandler(const StorageBase &storage, StoragePtr storagePtr) {
callStorageHandler(storage, storagePtr, &StorageHandler::m_doneHandler); callStorageHandler(storage, storagePtr, &StorageHandler::m_doneHandler);
} }
struct StorageHandler { struct StorageHandler {
@ -1880,7 +1880,7 @@ public:
StorageBase::StorageHandler m_doneHandler = {}; StorageBase::StorageHandler m_doneHandler = {};
}; };
typedef StorageBase::StorageHandler StorageHandler::*HandlerPtr; // ptr to class member typedef StorageBase::StorageHandler StorageHandler::*HandlerPtr; // ptr to class member
void callStorageHandler(StorageBase storage, StoragePtr storagePtr, HandlerPtr ptr) void callStorageHandler(const StorageBase &storage, StoragePtr storagePtr, HandlerPtr ptr)
{ {
const auto it = m_storageHandlers.constFind(storage); const auto it = m_storageHandlers.constFind(storage);
if (it == m_storageHandlers.constEnd()) if (it == m_storageHandlers.constEnd())
@ -3525,8 +3525,8 @@ int TaskTree::progressValue() const
*/ */
void TaskTree::setupStorageHandler(const StorageBase &storage, void TaskTree::setupStorageHandler(const StorageBase &storage,
StorageBase::StorageHandler setupHandler, const StorageBase::StorageHandler &setupHandler,
StorageBase::StorageHandler doneHandler) const StorageBase::StorageHandler &doneHandler)
{ {
auto it = d->m_storageHandlers.find(storage); auto it = d->m_storageHandlers.find(storage);
if (it == d->m_storageHandlers.end()) { if (it == d->m_storageHandlers.end()) {

4
src/assets/downloader/tasking/tasktree.h
View File

@ -711,8 +711,8 @@ Q_SIGNALS:
private: private:
void setupStorageHandler(const StorageBase &storage, void setupStorageHandler(const StorageBase &storage,
StorageBase::StorageHandler setupHandler, const StorageBase::StorageHandler &setupHandler,
StorageBase::StorageHandler doneHandler); const StorageBase::StorageHandler &doneHandler);
template <typename StorageStruct, typename Handler> template <typename StorageStruct, typename Handler>
StorageBase::StorageHandler wrapHandler(Handler &&handler) { StorageBase::StorageHandler wrapHandler(Handler &&handler) {
return [handler](void *voidStruct) { return [handler](void *voidStruct) {