From 27803ba23ec4b111ebcc18886028c423f08ca0ef Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 15 May 2025 17:48:17 +0200 Subject: [PATCH] TaskTree: Fix some coverity scan issues (use const ref) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Coverity-Id: 462756 462761 462769 462773 Change-Id: I70db1a0084da78bd1d51aa5bdba94675be5757a4 Reviewed-by: Kai Köhne (cherry picked from commit 13fcffa4d658600c8e9d21880e5c617ac3a39106) Reviewed-by: Qt Cherry-pick Bot --- src/assets/downloader/tasking/tasktree.cpp | 10 +++++----- src/assets/downloader/tasking/tasktree.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/assets/downloader/tasking/tasktree.cpp b/src/assets/downloader/tasking/tasktree.cpp index f9d5cd46540..b9d563f2c10 100644 --- a/src/assets/downloader/tasking/tasktree.cpp +++ b/src/assets/downloader/tasking/tasktree.cpp @@ -1869,10 +1869,10 @@ public: void bumpAsyncCount(); void advanceProgress(int byValue); void emitDone(DoneWith result); - void callSetupHandler(StorageBase storage, StoragePtr storagePtr) { + void callSetupHandler(const StorageBase &storage, StoragePtr storagePtr) { callStorageHandler(storage, storagePtr, &StorageHandler::m_setupHandler); } - void callDoneHandler(StorageBase storage, StoragePtr storagePtr) { + void callDoneHandler(const StorageBase &storage, StoragePtr storagePtr) { callStorageHandler(storage, storagePtr, &StorageHandler::m_doneHandler); } struct StorageHandler { @@ -1880,7 +1880,7 @@ public: StorageBase::StorageHandler m_doneHandler = {}; }; typedef StorageBase::StorageHandler StorageHandler::*HandlerPtr; // ptr to class member - void callStorageHandler(StorageBase storage, StoragePtr storagePtr, HandlerPtr ptr) + void callStorageHandler(const StorageBase &storage, StoragePtr storagePtr, HandlerPtr ptr) { const auto it = m_storageHandlers.constFind(storage); if (it == m_storageHandlers.constEnd()) @@ -3525,8 +3525,8 @@ int TaskTree::progressValue() const */ void TaskTree::setupStorageHandler(const StorageBase &storage, - StorageBase::StorageHandler setupHandler, - StorageBase::StorageHandler doneHandler) + const StorageBase::StorageHandler &setupHandler, + const StorageBase::StorageHandler &doneHandler) { auto it = d->m_storageHandlers.find(storage); if (it == d->m_storageHandlers.end()) { diff --git a/src/assets/downloader/tasking/tasktree.h b/src/assets/downloader/tasking/tasktree.h index 75489ca87cc..731dffaffc4 100644 --- a/src/assets/downloader/tasking/tasktree.h +++ b/src/assets/downloader/tasking/tasktree.h @@ -711,8 +711,8 @@ Q_SIGNALS: private: void setupStorageHandler(const StorageBase &storage, - StorageBase::StorageHandler setupHandler, - StorageBase::StorageHandler doneHandler); + const StorageBase::StorageHandler &setupHandler, + const StorageBase::StorageHandler &doneHandler); template StorageBase::StorageHandler wrapHandler(Handler &&handler) { return [handler](void *voidStruct) {