1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QVulkanWindow::setEnabledFeatures2Modifier(): pass parameter by value

Browse Source 
The method takes an std::function as a parameter, so it makes sense to
pass it by value to avoid copying when passing lambdas.

Amends bd78047df34fda3a56b8db069fc97280831ac696

Found in 6.7 API review

Change-Id: Ic0608a176bfd26b5b44fae48f29d84737e81a413
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
(cherry picked from commit c5d0345c3d6177105c2a6cbb2f99ab6c64d333a8)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Ivan Solovev 2024-02-05 14:33:49 +01:00 committed by Qt Cherry-pick Bot
parent 40e56294f1
commit 09236abe2d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gui/vulkan/qvulkanwindow.cpp
View File

@ -1691,10 +1691,10 @@ void QVulkanWindow::setEnabledFeaturesModifier(const EnabledFeaturesModifier &mo
\since 6.7
\sa EnabledFeatures2Modifier
*/
void QVulkanWindow::setEnabledFeatures2Modifier(const EnabledFeatures2Modifier &modifier)
void QVulkanWindow::setEnabledFeatures2Modifier(EnabledFeatures2Modifier modifier)
{
Q_D(QVulkanWindow);
d->enabledFeatures2Modifier = modifier;
d->enabledFeatures2Modifier = std::move(modifier);
}
/*!

2
src/gui/vulkan/qvulkanwindow.h
View File

@ -89,7 +89,7 @@ public:
void setEnabledFeaturesModifier(const EnabledFeaturesModifier &modifier);
typedef std::function<void(VkPhysicalDeviceFeatures2 &)> EnabledFeatures2Modifier;
void setEnabledFeatures2Modifier(const EnabledFeatures2Modifier &modifier);
void setEnabledFeatures2Modifier(EnabledFeatures2Modifier modifier);
void setPreferredColorFormats(const QList<VkFormat> &formats);