From 09236abe2d74d06b7f01710ebfb346db41620072 Mon Sep 17 00:00:00 2001
From: Ivan Solovev <ivan.solovev@qt.io>
Date: Mon, 5 Feb 2024 14:33:49 +0100
Subject: [PATCH] QVulkanWindow::setEnabledFeatures2Modifier(): pass parameter
 by value

The method takes an std::function as a parameter, so it makes sense to
pass it by value to avoid copying when passing lambdas.

Amends bd78047df34fda3a56b8db069fc97280831ac696

Found in 6.7 API review

Change-Id: Ic0608a176bfd26b5b44fae48f29d84737e81a413
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
(cherry picked from commit c5d0345c3d6177105c2a6cbb2f99ab6c64d333a8)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/gui/vulkan/qvulkanwindow.cpp | 4 ++--
 src/gui/vulkan/qvulkanwindow.h   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/gui/vulkan/qvulkanwindow.cpp b/src/gui/vulkan/qvulkanwindow.cpp
index a2d3e49880d..e564fb71480 100644
--- a/src/gui/vulkan/qvulkanwindow.cpp
+++ b/src/gui/vulkan/qvulkanwindow.cpp
@@ -1691,10 +1691,10 @@ void QVulkanWindow::setEnabledFeaturesModifier(const EnabledFeaturesModifier &mo
     \since 6.7
     \sa EnabledFeatures2Modifier
 */
-void QVulkanWindow::setEnabledFeatures2Modifier(const EnabledFeatures2Modifier &modifier)
+void QVulkanWindow::setEnabledFeatures2Modifier(EnabledFeatures2Modifier modifier)
 {
     Q_D(QVulkanWindow);
-    d->enabledFeatures2Modifier = modifier;
+    d->enabledFeatures2Modifier = std::move(modifier);
 }
 
 /*!
diff --git a/src/gui/vulkan/qvulkanwindow.h b/src/gui/vulkan/qvulkanwindow.h
index d7933911c0b..5b69560456c 100644
--- a/src/gui/vulkan/qvulkanwindow.h
+++ b/src/gui/vulkan/qvulkanwindow.h
@@ -89,7 +89,7 @@ public:
     void setEnabledFeaturesModifier(const EnabledFeaturesModifier &modifier);
 
     typedef std::function<void(VkPhysicalDeviceFeatures2 &)> EnabledFeatures2Modifier;
-    void setEnabledFeatures2Modifier(const EnabledFeatures2Modifier &modifier);
+    void setEnabledFeatures2Modifier(EnabledFeatures2Modifier modifier);
 
     void setPreferredColorFormats(const QList<VkFormat> &formats);