1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QJniObject: fix signature of LocalFrame::newLocalRef

Browse Source 
The implementation calls a const member function on the QJniObject
passed in, and no move happens. And the parameter is not a universal
reference either.

Found during header review.

Task-number: QTBUG-119952
Change-Id: I9479df798178b089277aa230f50f4e73f38ceb2c
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
(cherry picked from commit a6151e2d35b67e628eb1a6932bec39e100a2d692)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Volker Hilsheimer 2024-01-23 11:32:59 +01:00 committed by Qt Cherry-pick Bot
parent 2cb6d38089
commit 0604ce57ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/kernel/qjniobject.h
View File

@ -40,7 +40,7 @@ class Q_CORE_EXPORT QJniObject
return static_cast<T>(jniEnv()->NewLocalRef(object)); return static_cast<T>(jniEnv()->NewLocalRef(object));
} }
template <typename T> template <typename T>
auto newLocalRef(QJniObject &&object) auto newLocalRef(const QJniObject &object)
{ {
return newLocalRef<T>(object.template object<T>()); return newLocalRef<T>(object.template object<T>());
} }