From 0604ce57eaf20176519e01cd4126a8a4a6eceec5 Mon Sep 17 00:00:00 2001
From: Volker Hilsheimer <volker.hilsheimer@qt.io>
Date: Tue, 23 Jan 2024 11:32:59 +0100
Subject: [PATCH] QJniObject: fix signature of LocalFrame::newLocalRef

The implementation calls a const member function on the QJniObject
passed in, and no move happens. And the parameter is not a universal
reference either.

Found during header review.

Task-number: QTBUG-119952
Change-Id: I9479df798178b089277aa230f50f4e73f38ceb2c
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
(cherry picked from commit a6151e2d35b67e628eb1a6932bec39e100a2d692)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/corelib/kernel/qjniobject.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/corelib/kernel/qjniobject.h b/src/corelib/kernel/qjniobject.h
index 292596d2089..178a4b7faac 100644
--- a/src/corelib/kernel/qjniobject.h
+++ b/src/corelib/kernel/qjniobject.h
@@ -40,7 +40,7 @@ class Q_CORE_EXPORT QJniObject
             return static_cast<T>(jniEnv()->NewLocalRef(object));
         }
         template <typename T>
-        auto newLocalRef(QJniObject &&object)
+        auto newLocalRef(const QJniObject &object)
         {
             return newLocalRef<T>(object.template object<T>());
         }