1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: show stderr on v8 coverage test failures

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/26513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
This commit is contained in:
Joyee Cheung 2019-03-08 11:53:15 +01:00
parent 0a3bcdd261
commit eb0bf8d307
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/parallel/test-v8-coverage.js
View File

@ -22,6 +22,9 @@ function nextdir() {
const output = spawnSync(process.execPath, [ const output = spawnSync(process.execPath, [
require.resolve('../fixtures/v8-coverage/basic') require.resolve('../fixtures/v8-coverage/basic')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (output.status !== 0) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 0); assert.strictEqual(output.status, 0);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('basic.js', coverageDirectory); const fixtureCoverage = getFixtureCoverage('basic.js', coverageDirectory);
@ -38,6 +41,9 @@ function nextdir() {
const output = spawnSync(process.execPath, [ const output = spawnSync(process.execPath, [
require.resolve('../fixtures/v8-coverage/exit-1') require.resolve('../fixtures/v8-coverage/exit-1')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (output.status !== 1) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 1); assert.strictEqual(output.status, 1);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('exit-1.js', coverageDirectory); const fixtureCoverage = getFixtureCoverage('exit-1.js', coverageDirectory);
@ -55,6 +61,9 @@ function nextdir() {
require.resolve('../fixtures/v8-coverage/sigint') require.resolve('../fixtures/v8-coverage/sigint')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (!common.isWindows) { if (!common.isWindows) {
if (output.signal !== 'SIGINT') {
console.log(output.stderr.toString());
}
assert.strictEqual(output.signal, 'SIGINT'); assert.strictEqual(output.signal, 'SIGINT');
} }
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
@ -72,6 +81,9 @@ function nextdir() {
const output = spawnSync(process.execPath, [ const output = spawnSync(process.execPath, [
require.resolve('../fixtures/v8-coverage/spawn-subprocess') require.resolve('../fixtures/v8-coverage/spawn-subprocess')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (output.status !== 0) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 0); assert.strictEqual(output.status, 0);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('subprocess.js', const fixtureCoverage = getFixtureCoverage('subprocess.js',
@ -89,6 +101,9 @@ function nextdir() {
const output = spawnSync(process.execPath, [ const output = spawnSync(process.execPath, [
require.resolve('../fixtures/v8-coverage/worker') require.resolve('../fixtures/v8-coverage/worker')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (output.status !== 0) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 0); assert.strictEqual(output.status, 0);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('subprocess.js', const fixtureCoverage = getFixtureCoverage('subprocess.js',
@ -106,6 +121,9 @@ function nextdir() {
const output = spawnSync(process.execPath, [ const output = spawnSync(process.execPath, [
require.resolve('../fixtures/v8-coverage/spawn-subprocess-no-cov') require.resolve('../fixtures/v8-coverage/spawn-subprocess-no-cov')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (output.status !== 0) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 0); assert.strictEqual(output.status, 0);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('subprocess.js', const fixtureCoverage = getFixtureCoverage('subprocess.js',
@ -119,6 +137,9 @@ function nextdir() {
const output = spawnSync(process.execPath, [ const output = spawnSync(process.execPath, [
require.resolve('../fixtures/v8-coverage/async-hooks') require.resolve('../fixtures/v8-coverage/async-hooks')
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
if (output.status !== 0) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 0); assert.strictEqual(output.status, 0);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('async-hooks.js', const fixtureCoverage = getFixtureCoverage('async-hooks.js',
@ -138,6 +159,9 @@ function nextdir() {
cwd: tmpdir.path, cwd: tmpdir.path,
env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory }
}); });
if (output.status !== 0) {
console.log(output.stderr.toString());
}
assert.strictEqual(output.status, 0); assert.strictEqual(output.status, 0);
assert.strictEqual(output.stderr.toString(), ''); assert.strictEqual(output.stderr.toString(), '');
const fixtureCoverage = getFixtureCoverage('basic.js', const fixtureCoverage = getFixtureCoverage('basic.js',