From eb0bf8d3077f7fd4d09f187b8bb8290ec8f8171b Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 8 Mar 2019 11:53:15 +0100 Subject: [PATCH] test: show stderr on v8 coverage test failures PR-URL: https://github.com/nodejs/node/pull/26513 Reviewed-By: Anna Henningsen Reviewed-By: Ben Coe --- test/parallel/test-v8-coverage.js | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/test/parallel/test-v8-coverage.js b/test/parallel/test-v8-coverage.js index 5c3db7af2cf..f002604c48e 100644 --- a/test/parallel/test-v8-coverage.js +++ b/test/parallel/test-v8-coverage.js @@ -22,6 +22,9 @@ function nextdir() { const output = spawnSync(process.execPath, [ require.resolve('../fixtures/v8-coverage/basic') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 0) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 0); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('basic.js', coverageDirectory); @@ -38,6 +41,9 @@ function nextdir() { const output = spawnSync(process.execPath, [ require.resolve('../fixtures/v8-coverage/exit-1') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 1) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 1); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('exit-1.js', coverageDirectory); @@ -55,6 +61,9 @@ function nextdir() { require.resolve('../fixtures/v8-coverage/sigint') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); if (!common.isWindows) { + if (output.signal !== 'SIGINT') { + console.log(output.stderr.toString()); + } assert.strictEqual(output.signal, 'SIGINT'); } assert.strictEqual(output.stderr.toString(), ''); @@ -72,6 +81,9 @@ function nextdir() { const output = spawnSync(process.execPath, [ require.resolve('../fixtures/v8-coverage/spawn-subprocess') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 0) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 0); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('subprocess.js', @@ -89,6 +101,9 @@ function nextdir() { const output = spawnSync(process.execPath, [ require.resolve('../fixtures/v8-coverage/worker') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 0) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 0); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('subprocess.js', @@ -106,6 +121,9 @@ function nextdir() { const output = spawnSync(process.execPath, [ require.resolve('../fixtures/v8-coverage/spawn-subprocess-no-cov') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 0) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 0); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('subprocess.js', @@ -119,6 +137,9 @@ function nextdir() { const output = spawnSync(process.execPath, [ require.resolve('../fixtures/v8-coverage/async-hooks') ], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 0) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 0); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('async-hooks.js', @@ -138,6 +159,9 @@ function nextdir() { cwd: tmpdir.path, env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } }); + if (output.status !== 0) { + console.log(output.stderr.toString()); + } assert.strictEqual(output.status, 0); assert.strictEqual(output.stderr.toString(), ''); const fixtureCoverage = getFixtureCoverage('basic.js',