1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: properly extend process.env in child_process

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/22430
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This commit is contained in:
Lucas Woo 2018-08-21 17:09:11 +08:00 committed by George Adams
parent 09fce8562a
commit dca2f9849c
No known key found for this signature in database
GPG Key ID: 7B8D7E4421A0916D
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-child-process-env.js
View File

@ -26,23 +26,21 @@ const os = require('os');
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
const env = { const env = Object.assign({}, process.env, {
'HELLO': 'WORLD', 'HELLO': 'WORLD',
'UNDEFINED': undefined, 'UNDEFINED': undefined,
'NULL': null, 'NULL': null,
'EMPTY': '' 'EMPTY': ''
}; });
Object.setPrototypeOf(env, { Object.setPrototypeOf(env, {
'FOO': 'BAR' 'FOO': 'BAR'
}); });
let child; let child;
if (common.isWindows) { if (common.isWindows) {
child = spawn('cmd.exe', ['/c', 'set'], child = spawn('cmd.exe', ['/c', 'set'], { env });
Object.assign({}, process.env, { env }));
} else { } else {
child = spawn('/usr/bin/env', [], child = spawn('/usr/bin/env', [], { env });
Object.assign({}, process.env, { env }));
} }