From dca2f9849c853b8a151732022d853d1a44dc708e Mon Sep 17 00:00:00 2001
From: Lucas Woo <legendecas@gmail.com>
Date: Tue, 21 Aug 2018 17:09:11 +0800
Subject: [PATCH] test: properly extend process.env in child_process

PR-URL: https://github.com/nodejs/node/pull/22430
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
---
 test/parallel/test-child-process-env.js | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/test/parallel/test-child-process-env.js b/test/parallel/test-child-process-env.js
index a819c5a64ee..2eec6588725 100644
--- a/test/parallel/test-child-process-env.js
+++ b/test/parallel/test-child-process-env.js
@@ -26,23 +26,21 @@ const os = require('os');
 
 const spawn = require('child_process').spawn;
 
-const env = {
+const env = Object.assign({}, process.env, {
   'HELLO': 'WORLD',
   'UNDEFINED': undefined,
   'NULL': null,
   'EMPTY': ''
-};
+});
 Object.setPrototypeOf(env, {
   'FOO': 'BAR'
 });
 
 let child;
 if (common.isWindows) {
-  child = spawn('cmd.exe', ['/c', 'set'],
-                Object.assign({}, process.env, { env }));
+  child = spawn('cmd.exe', ['/c', 'set'], { env });
 } else {
-  child = spawn('/usr/bin/env', [],
-                Object.assign({}, process.env, { env }));
+  child = spawn('/usr/bin/env', [], { env });
 }