1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix assumption of worker exit on disconnect

Browse Source 
Master was disconnecting its workers as soon as they both started up.
Meanwhile, the workers were trying to listen. Its a race, sometimes the
disconnect would happen between when worker gets the response message,
and acks that message with a 'listening'. This worked OK after v0.11
introduced a behaviour where disconnect would always exit the worker,
but once that backwards-incompatible behaviour is removed, the worker
lives long enough to try and respond to the master, and child_process
errors at the attempt to send from a disconnected child.
This commit is contained in:
Sam Roberts 2013-12-30 21:36:49 -08:00 committed by Timothy J Fontaine
parent 876d3bd85a
commit cb1646f44e
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/fixtures/clustered-server/app.js vendored
View File

@ -13,9 +13,6 @@ if (cluster.isMaster) {
cluster.on('online', function() {
if (++workersOnline === NUMBER_OF_WORKERS) {
console.error('all workers are running');
for (var key in cluster.workers) {
cluster.workers[key].disconnect();
}
}
});

5
test/simple/test-debug-cluster.js
View File

@ -35,11 +35,16 @@ child.stderr.on('data', function(data) {
if (line === 'all workers are running') {
assertOutputLines();
process.exit();
} else {
outputLines = outputLines.concat(lines);
}
});
process.on('exit', function onExit() {
child.kill();
});
var assertOutputLines = common.mustCall(function() {
var expectedLines = [
'Debugger listening on port ' + 5858,

5
test/simple/test-debug-port-cluster.js
View File

@ -41,11 +41,16 @@ child.stderr.on('data', function(data) {
if (line === 'all workers are running') {
assertOutputLines();
process.exit();
} else {
outputLines = outputLines.concat(lines);
}
});
process.on('exit', function onExit() {
child.kill();
});
var assertOutputLines = common.mustCall(function() {
var expectedLines = [
'Debugger listening on port ' + port,