1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cluster: do not synchronously emit 'setup' event

Browse Source 
This is a problem present in both v0.10, and v0.11, where the 'setup'
event is synchronously emitted by `cluster.setupMaster()`, a mostly
harmless anti-pattern.
This commit is contained in:
Sam Roberts 2013-12-17 16:04:20 -08:00 committed by Timothy J Fontaine
parent dce35146e0
commit 876d3bd85a
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/cluster.js
View File

@ -269,7 +269,9 @@ function masterInit() {
process._debugProcess(cluster.workers[key].process.pid);
});
cluster.emit('setup');
process.nextTick(function() {
cluster.emit('setup');
});
};
var ids = 0;

12
test/simple/test-cluster-setup-master.js
View File

@ -39,6 +39,12 @@ if (cluster.isWorker) {
var totalWorkers = 2;
// Setup master
cluster.setupMaster({
args: ['custom argument'],
silent: true
});
cluster.once('setup', function() {
checks.setupEvent = true;
@ -51,12 +57,6 @@ if (cluster.isWorker) {
}
});
// Setup master
cluster.setupMaster({
args: ['custom argument'],
silent: true
});
var correctIn = 0;
cluster.on('online', function lisenter(worker) {