1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

path: Do not coerce paths to strings on Windows

Browse Source 
Fix #4795
This commit is contained in:
isaacs 2013-02-18 10:46:50 -08:00
parent 9d10bf58a3
commit bbcb8b3ae0
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/path.js
View File

@ -448,7 +448,9 @@ exports.existsSync = util.deprecate(function(path) {
if (isWindows) { if (isWindows) {
exports._makeLong = function(path) { exports._makeLong = function(path) {
path = '' + path; if (typeof path !== 'string')
return path;
if (!path) { if (!path) {
return ''; return '';
} }

14
test/simple/test-path-makelong.js
View File

@ -19,11 +19,11 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
if (process.platform === 'win32') { var assert = require('assert');
var assert = require('assert'); var path = require('path');
var path = require('path'); var common = require('../common');
var common = require('../common');
if (process.platform === 'win32') {
var file = path.join(common.fixturesDir, 'a.js'); var file = path.join(common.fixturesDir, 'a.js');
var resolvedFile = path.resolve(file); var resolvedFile = path.resolve(file);
@ -36,3 +36,9 @@ if (process.platform === 'win32') {
assert.equal('\\\\.\\pipe\\somepipe', assert.equal('\\\\.\\pipe\\somepipe',
path._makeLong('\\\\.\\pipe\\somepipe')); path._makeLong('\\\\.\\pipe\\somepipe'));
} }
assert.equal(path._makeLong(null), null);
assert.equal(path._makeLong(100), 100);
assert.equal(path._makeLong(path), path);
assert.equal(path._makeLong(false), false);
assert.equal(path._makeLong(true), true);