1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stream_wrap: remove superfluous buffer len check

Browse Source 
It's a buffer so it's never bigger than Buffer::kMaxLength bytes,
which in turn is always < INT_MAX.
This commit is contained in:
Ben Noordhuis 2013-02-20 22:06:41 +01:00
parent 6ad792610b
commit 9d10bf58a3
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/stream_wrap.cc
View File

@ -293,14 +293,6 @@ Handle<Value> StreamWrap::WriteBuffer(const Arguments& args) {
Local<Object> buffer_obj = args[0]->ToObject();
size_t offset = 0;
size_t length = Buffer::Length(buffer_obj);
if (length > INT_MAX) {
uv_err_t err;
err.code = UV_ENOBUFS;
SetErrno(err);
return scope.Close(v8::Null(node_isolate));
}
char* storage = new char[sizeof(WriteWrap)];
WriteWrap* req_wrap = new (storage) WriteWrap();
@ -317,7 +309,8 @@ Handle<Value> StreamWrap::WriteBuffer(const Arguments& args) {
StreamWrap::AfterWrite);
req_wrap->Dispatched();
req_wrap->object_->Set(bytes_sym, Number::New((uint32_t) length));
req_wrap->object_->Set(bytes_sym,
Integer::NewFromUnsigned(length, node_isolate));
wrap->UpdateWriteQueueSize();